Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added NFS costs #247

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added NFS costs #247

wants to merge 6 commits into from

Conversation

marco-porru
Copy link
Contributor

Introduced computation of additional costs

@marco-porru marco-porru requested a review from a team as a code owner December 3, 2024 11:31
@marco-porru marco-porru marked this pull request as draft December 3, 2024 11:31
@PlamiIG
Copy link
Contributor

PlamiIG commented Dec 3, 2024

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

@PlamiIG PlamiIG added ua-review Under review by the UA team type/content-gaps Something essential is missing in the documentation. labels Dec 3, 2024
@marco-porru
Copy link
Contributor Author

@PlamiIG Thanks for taking care of it. But please hold on a while, it's still a draft. I'll ping you as soon as I'm done with the update :)

@NHingerl
Copy link
Contributor

NHingerl commented Dec 3, 2024

@marco-porru - @PlamiIG distributed it to the author in charge: I will take care of this.

@marco-porru marco-porru marked this pull request as ready for review December 3, 2024 15:38
@marco-porru
Copy link
Contributor Author

@NHingerl Please review it.
I also included the modification to the price estimator.

@@ -262,7 +262,7 @@ Number of CU per Hour
</tr>
</table>

**For Storage**
**For Standard Storage**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "Standard" here can be misleading... We already use the word to describe the Service Plan. Maybe "Basic" instead? or leave this just as it was and add "Premium" as a differentiation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, isn't it still the same "kind" of storage - just priced differently? It's not that for premium, the hardware is gold-plated? :D
So basically, what concretely is it that makes premium storage "premium" and doesn't allow putting it into the same category (just with 3x higher price) as the existing "For Storage" (vs "For CPU")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's exactly the reason why it's more expensive. It's a more performant storage, it should offer a better I/O, but also support additional capabilities not covered by the standard storage like read write from more then one pod.

So yes both are storages but one is more expensive because it's a different architecture for storage and provide additional features.

it's like HANA and sqlite... both are databases, yes, but can we consider HANA as a premium db and SQLite as a basic database?


Certain features of Cloud Manager may initiate additional hardware resources in the cloud provider account. These features could potentially incur extra costs based on the resources you implement.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Certain features" sounds vague. Do we know which features? Can we be more specific here?

May they initiate additional hardware resources? or is that certain?
These features could potentially incur extra costs based on the resources you implement or is that certain?
How do the users know that the potential extra costs are applicable to them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Cloud Manager? We can't assume that readers of this document have any idea about this specific module, or in fact about Kyma modules in general. We should start with a sentence that these "Additional Costs" are specific to users of the Cloud Manager module (if I don't misunderstand the situation). These aren't generic "additional costs", they have a clearly defined scope and target group.

I concur with Gosia that the whole paragraph is extremely vague.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct


Certain features of Cloud Manager may initiate additional hardware resources in the cloud provider account. These features could potentially incur extra costs based on the resources you implement.
All additional costs are calculated using a baseline formula, which is a combination of the two metrics used to compute other Kyma costs: **CPU** and **Storage**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the formula from the Backward Calculation section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph talks about CPU and storage, but the table below only mentions (premium) storage and never again talks about CPU. So what is there to say about CPU in the context of "additional cost"?
And if "premium" CPU is identical to normal CPU and doesn't deserve mentioning again, why not put "premium" storage next to its "basic" sibling instead of opening a whole new section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in general, to derive the costs introduced for the cloud manager "premium" storage and Redis, we combine the storage metric and/or the node calculation metric in a formula. For example, at the moment, 64 GB premium storage = 3* 64 GB standard storage. For Redis, it's not a linear formula: you have to match the GB in a table.

When we will introduce the worker pools and additional machine types it will be 1 node = xgeneric purpose node and/ystorage


#### Premium Storage

Premium storage can be enabled using Cloud Manager and will create storage using NFS technology.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When someone adds the Cloud Manager Module do they already start using the premium storage? What are the prerequisites?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur, it's unclear if this is automatic or manual, and whether it is avoidable for Cloud Manager users.

Could this sentence be rephrased to:
"If you use the Cloud Manager module, you automatically get premium storage with NFS technology." or something similar.

Also, what is "NFS"? It seems to be important (otherwise you could just drop the last three words), but it's explained nowhere. Is normal storage created with some other technology? If yes, why does the difference matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. should we include the definition as here --> https://en.wikipedia.org/wiki/Network_File_System ?

We must provide another definition, like:
"If you use the Cloud Manager module, you can create and consume premium storage with NFS technology."

this is not automatic, but the cloud manager module is a requirement to start creating and consuming it

#### Premium Storage

Premium storage can be enabled using Cloud Manager and will create storage using NFS technology.
The pricing for premium storage is based on the storage metrics and is scaled up by a factor of **3** compared to standard storage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 310 you wrote that the additional costs are calculated using the basic formula. So actually is the formula the same as for the standard storage or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premium it's 3*standard storage formula. so it's the formula of the standard storage but scaled by a factor 3. How can we write it?


#### Cloud-managed Redis

When deployed with the Cloud Manager module, Redis creates a cluster in the Kyma's cloud provider account and begins consuming new, dedicated machines.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by deployed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be changed to something like

When Redis is deployed with the Cloud Manager module, it creates a Redis cluster in the Kyma's cloud provider account and begins consuming new, dedicated machines.

@@ -304,7 +304,79 @@ Number of CU per Hour
</tr>
</table>

### Additional Costs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean? Can we write clearly what the additional costs refer to already in the headline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that.

Also, this introduces the "Additional Costs" as something different from the "Underlying Metrics"; as it's another headline on the same level. But aren't the "premium costs" still a kind of underlying metric? Just a special one, for a limited group of users (who probably can opt in to use that service and incur the cost).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wrong wording here. We must highlight that there are, potentially, other costs. These costs could be introduced by consuming features from cloud manager (for example redis). SOmething more in the future?

Certain features of Cloud Manager may initiate additional hardware resources in the cloud provider account. These features could potentially incur extra costs based on the resources you implement.
All additional costs are calculated using a baseline formula, which is a combination of the two metrics used to compute other Kyma costs: **CPU** and **Storage**.

#### Premium Storage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it called premium? What does it mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, I'm open to any other definition. the short answer is: because it's the terminology used in the price estimator.

@@ -262,7 +262,7 @@ Number of CU per Hour
</tr>
</table>

**For Storage**
**For Standard Storage**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, isn't it still the same "kind" of storage - just priced differently? It's not that for premium, the hardware is gold-plated? :D
So basically, what concretely is it that makes premium storage "premium" and doesn't allow putting it into the same category (just with 3x higher price) as the existing "For Storage" (vs "For CPU")

@@ -304,7 +304,79 @@ Number of CU per Hour
</tr>
</table>

### Additional Costs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that.

Also, this introduces the "Additional Costs" as something different from the "Underlying Metrics"; as it's another headline on the same level. But aren't the "premium costs" still a kind of underlying metric? Just a special one, for a limited group of users (who probably can opt in to use that service and incur the cost).


Certain features of Cloud Manager may initiate additional hardware resources in the cloud provider account. These features could potentially incur extra costs based on the resources you implement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Cloud Manager? We can't assume that readers of this document have any idea about this specific module, or in fact about Kyma modules in general. We should start with a sentence that these "Additional Costs" are specific to users of the Cloud Manager module (if I don't misunderstand the situation). These aren't generic "additional costs", they have a clearly defined scope and target group.

I concur with Gosia that the whole paragraph is extremely vague.


Certain features of Cloud Manager may initiate additional hardware resources in the cloud provider account. These features could potentially incur extra costs based on the resources you implement.
All additional costs are calculated using a baseline formula, which is a combination of the two metrics used to compute other Kyma costs: **CPU** and **Storage**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph talks about CPU and storage, but the table below only mentions (premium) storage and never again talks about CPU. So what is there to say about CPU in the context of "additional cost"?
And if "premium" CPU is identical to normal CPU and doesn't deserve mentioning again, why not put "premium" storage next to its "basic" sibling instead of opening a whole new section?


#### Premium Storage

Premium storage can be enabled using Cloud Manager and will create storage using NFS technology.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur, it's unclear if this is automatic or manual, and whether it is avoidable for Cloud Manager users.

Could this sentence be rephrased to:
"If you use the Cloud Manager module, you automatically get premium storage with NFS technology." or something similar.

Also, what is "NFS"? It seems to be important (otherwise you could just drop the last three words), but it's explained nowhere. Is normal storage created with some other technology? If yes, why does the difference matter?

| P5 | 101 | 30363 | 12335 |
| P6 | 200 | 60704 | 24661 |

NB: **Approx. Available Size (GiB)** might vary depending on the cloud provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this means nota bene: We never use latin abbreviations in documentation.
Use "Note", or just format it as normal sentence without any intro phrase.


| **Tier** | **Approx. Available Size (GiB)** | **Cost expressed in Storage size** | **Cost in CU** |
|:--------: |:--------------------------------: |-----------------------------------: |---------------: |
| S1 | 1 | 182 | 74 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which units belong to these naked numbers?
CPU is counted in nodes, storage in GB, and I assume cost would be Euros? But we don't and shouldn't state any actual prices in this doc. So what exactly do the last two columns mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's exactly what in the header, no euro. it's "the equivalent storage space you are consuming". SO having 1 gb of redis cache in terms of storage (and storage costs) is like having 182 gb storage

@@ -335,9 +407,9 @@ Find the Kyma price calculator on [https://kyma-project.github.io/price-calculat

2. Choose the **minimum of VMs** you need.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping the steps to estimate the hours per month and the optional addition of more nodes? Did the functionality and UI of the Kyma cost calculator change?

Are the new two steps replacements for the old steps?
Are the new two steps valid for all readers, or just for Cloud Manager/Redis customers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's misleading. You cannot pause or hibernate a cluster or storage. It was also removed from the price estimator. because it was completely misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/content-gaps Something essential is missing in the documentation. ua-review Under review by the UA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants