Skip to content

Add AI migration#9

Merged
svgradev merged 2 commits intomainfrom
migai
May 7, 2026
Merged

Add AI migration#9
svgradev merged 2 commits intomainfrom
migai

Conversation

@mayaStefanovaSap
Copy link
Copy Markdown
Member

@mayaStefanovaSap mayaStefanovaSap commented May 5, 2026

This pull request introduces a comprehensive, AI-assisted framework for migrating SAP BTP Neo applications to the Cloud Foundry environment. The framework is built upon a set of modular "AI Skills" designed for use with AI coding assistants like Claude Code, GitHub Copilot, and Cursor.
Key highlights of this new framework include:

  • AI Agent Skills: A library of 22 modular skills under the ai-migration directory that handle specific transformations, from foundational Java 25/Jakarta EE 10 upgrades to complex security and service migrations.
  • Orchestrator Skills: New orchestrator skills (neo-to-cf-migration-orchestrator, subaccount-migration-orchestrator) analyze an application or subaccount and automatically execute the required migration skills in the correct dependency order.
  • Upgrade to Java 25: The migration target for applications has been updated from Java 17 to Java 25.This pull request introduces a comprehensive, AI-assisted framework for migrating SAP BTP Neo applications to the Cloud Foundry environment. The framework is built upon a set of modular "AI Skills" designed for use with AI coding assistants like Claude Code, GitHub Copilot, and Cursor.
    Key highlights of this new framework include:
  • AI Agent Skills: A library of 22 modular skills under the ai-migration directory that handle specific transformations, from foundational Java 25/Jakarta EE 10 upgrades to complex security and service migrations.
  • Orchestrator Skills: New orchestrator skills (neo-to-cf-migration-orchestrator, subaccount-migration-orchestrator) analyze an application or subaccount and automatically execute the required migration skills in the correct dependency order.
  • Upgrade to Java 25: The migration target for applications has been updated from Java 17 to Java 25.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 5, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mayaStefanovaSap mayaStefanovaSap requested a review from i028409 May 5, 2026 11:20
@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

Version inconsistency in plugin manifests

marketplace.json declares version 1.1.0 while plugin.json declares version 1.0.8. These should be aligned to avoid confusion about which version is actually installed.

  • ai-migration/neo-java-migration-marketplace/.claude-plugin/marketplace.json"version": "1.1.0"
  • ai-migration/neo-java-migration-skills-plugin/.claude-plugin/plugin.json"version": "1.0.8"

@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

target removed from .gitignore

The original .gitignore had target (Maven build output directory). It was removed in this PR, which means compiled artifacts could accidentally be committed. This should be restored:

target

@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

README skill count inconsistency

The README and marketplace description state "12 modular migration skills" in multiple places, but the PR actually contains 22 skills (based on the number of SKILL.md files). Please update the count to reflect the actual number.

Affected files:

  • ai-migration/README.md (mentions "12" in multiple sections)
  • ai-migration/neo-java-migration-skills-plugin/marketplace/description.md

@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

TomEE scenario: resources.xml relocation unexplained

scenarios/tomee/cf/src/main/webapp/META-INF/resources.xml was deleted and recreated at scenarios/tomee/cf/src/main/webapp/WEB-INF/resources.xml. Could you add a note explaining why the file was moved? This helps future contributors understand the reasoning (e.g., TomEE convention vs. Tomcat convention).

@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

Missing PR description

The PR body is empty. For a 15K+ line PR, a summary would be very helpful for reviewers — what's included, how to test, any breaking changes, etc.

@i028409
Copy link
Copy Markdown

i028409 commented May 5, 2026

README references non-existent files

The plugin structure section in ai-migration/README.md and links throughout reference files that are not included in this PR:

  • docs/MIGRATION-GUIDE.md
  • docs/examples/
  • CHANGELOG.md
  • LICENSE
  • marketplace/icon.svg
  • marketplace/screenshot-1.png

Either add these files or remove the references to avoid dead links.

@SAP-samples SAP-samples locked and limited conversation to collaborators May 7, 2026
@SAP-samples SAP-samples unlocked this conversation May 7, 2026
Copy link
Copy Markdown

@i028409 i028409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svgradev svgradev merged commit 1662fa1 into main May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants