Skip to content

Conversation

@TheRealMDoerr
Copy link
Member

@TheRealMDoerr TheRealMDoerr commented Dec 10, 2025

Enable UseTransparentHugePages by default if the machine and JVM configuration are suited for their usage. Some tests need a small adaptation to support that.

fixes #2137

@SapMachine
Copy link
Member

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

@RealCLanger
Copy link
Member

I think this looks good but I'm wondering whether it's possible to do the changes to the tests in OpenJDK? It should not be wrong there, no?

Copy link
Contributor

@dbriemann dbriemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheRealMDoerr
Copy link
Member Author

I think this looks good but I'm wondering whether it's possible to do the changes to the tests in OpenJDK? It should not be wrong there, no?

I would like to have them in OpenJDK because they do no harm. However, I don't have any justification for such changes without changing the default of UseTransparentHugePages. Note that these tests use @requires vm.flagless.

@MBaesken
Copy link
Member

MBaesken commented Dec 11, 2025

java.md mentions UseTransparentHugePages

https://github.com/openjdk/jdk/blob/692edc4879489d44a477a03028eb3e7ef9dff388/src/java.base/share/man/java.md?plain=1#L1579

Seems what is said is not true now any more for SapMachine; not sure how important it is but might be better to adjust (of course in SapMachine) ?

@SapMachine
Copy link
Member

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

@RealCLanger
Copy link
Member

I think this looks good but I'm wondering whether it's possible to do the changes to the tests in OpenJDK? It should not be wrong there, no?

I would like to have them in OpenJDK because they do no harm. However, I don't have any justification for such changes without changing the default of UseTransparentHugePages. Note that these tests use @requires vm.flagless.

Yes, I see your point, it's hard to motivate in OpenJDK, I guess.

@TheRealMDoerr TheRealMDoerr merged commit aece2fb into sapmachine Dec 12, 2025
139 of 142 checks passed
@TheRealMDoerr TheRealMDoerr deleted the 2137_TransparentHugePages branch December 12, 2025 14:16
TheRealMDoerr added a commit that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux: We should use transparent huge pages in some configurations

6 participants