-
Notifications
You must be signed in to change notification settings - Fork 101
SapMachine #2137: Linux: We should use transparent huge pages in some configurations #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… configurations
|
Hello @TheRealMDoerr, this pull request fulfills all formal requirements. |
|
Hello @TheRealMDoerr, this pull request fulfills all formal requirements. |
|
I think this looks good but I'm wondering whether it's possible to do the changes to the tests in OpenJDK? It should not be wrong there, no? |
dbriemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I would like to have them in OpenJDK because they do no harm. However, I don't have any justification for such changes without changing the default of |
|
java.md mentions UseTransparentHugePages Seems what is said is not true now any more for SapMachine; not sure how important it is but might be better to adjust (of course in SapMachine) ? |
|
Hello @TheRealMDoerr, this pull request fulfills all formal requirements. |
Yes, I see your point, it's hard to motivate in OpenJDK, I guess. |
… some configurations (#2138)
Enable UseTransparentHugePages by default if the machine and JVM configuration are suited for their usage. Some tests need a small adaptation to support that.
fixes #2137