-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Use popper for popovers (#467)
* Implemented react-popper for popovers * Removed clickHandler prop to let onClick filter through * Abstracted react-popper functionality to an internal component * Updated jest config to support popper.js and updated Popover tests * Added out-of-boundaries handling and changed popper to default to no portal * Removed default placement * Updated examples * Updated tests and components to match new Popover API * Remove unused code blocks * Updates to Popover component page * Fixed tests for TimePicker and LocalizationEditor * Updated components, tests and snapshots * Updated size limit * Split out popper-based styles into separate scss file
- Loading branch information
1 parent
683c9c3
commit a46c9c4
Showing
34 changed files
with
1,324 additions
and
3,817 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,6 @@ | |
name: "Fundamental-React Size", | ||
webpack: true, | ||
path: "lib/index.js", | ||
limit: "40 KB" | ||
limit: "50 KB" | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import PopperJs from 'popper.js'; | ||
|
||
export default class Popper { | ||
static placements = PopperJs.placements; | ||
|
||
constructor() { | ||
return { | ||
destroy: () => { }, | ||
scheduleUpdate: () => { } | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.