feat: Enable Adaptation Editor for CF projects #3790
Conversation
nikmace
added
preview-middleware
🦋 Changeset detectedLatest commit: 5f9257f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@nikmace Using CF to discover systems and connect is something we already support using axios-extension and https://github.com/SAP/open-ux-tools/blob/main/packages/odata-service-inquirer/src/prompts/datasources/sap-system/abap-on-btp/questions.ts#L216. Is this not sufficent for this use case. Any connectivity features should be added to axios extension, but I believe there is nothing new here? |
Our use case is completely different. We are trying to support Cloud Foundry Adaptation Projects in the Adaptation Editor - that is the goal. We are not having issues with connectivity, and I don't see a reason to enhance axios-extension because we don't need to use any methods from it like we do with AbapServiceProvider (ABAP and Cloud Foundry are two different things). All we need to do is get the service keys from business service, make a call to fetch an authorization token, and attach it to the request headers. Then, authentication is going to happen programatically, service-to-service. For example, for OData, which is linked to a destination and needs authorization. Maybe I don't understand something but I can't see how enhacing axios-extension is going to help us. We are talking about different scenarios, in my opinion. Let's follow up during the meeting. 👍🏻 |
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
See comments. I just had a look at the backend-proxy-middleware-cf and preview-middleware changes. Can't really comment on the adp packages.
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
- review comments have been addressed
- test coverage is great
- changeset exists
- code changes to
preview-middleware& new cf proxy middleware looks good (did not reviewadp-toolingandgenerator-adppackages) - did NOT test manually
testojs
left a comment
testojs
left a comment
There was a problem hiding this comment.
- change looks good
- changeset is OK
- excellent test coverage
- do not test manually
voicis
left a comment
voicis
left a comment
There was a problem hiding this comment.
Reapproving. Tests passing https://github.com/SAP/open-ux-tools/actions/runs/19861562961
|
After this PR is merged, I've prepared a PR to fix ADP UI integration tests and run the Jenkins job (1280) against the branch in the private repo. |
|
…riter/custom-filter-fields-in-multiple-filterbar * 'main' of github.com:SAP/open-ux-tools: chore: apply latest changesets fix: mcp server load the latest embeddings package on install/ npx (#3897) chore: apply latest changesets feat(project-access): support reading path mappings for other types than application (#3866) chore: apply latest changesets fix: update vocabularies (#3902) chore: apply latest changesets feat: Enable Adaptation Editor for CF projects (#3790) chore: remove outdated ui5 cli and specification artefacts from package.json files (#3874) chore: apply latest changesets chore(fiori-mcp): bump package versions (#3893) test: failing tests (#3886)
Feat for #3789.