Tool taking bibtex file and giving output md rf #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copernico
reviewed
Jul 23, 2024
scripts/bib2md.py
Outdated
| def main(): | ||
| parser = argparse.ArgumentParser() | ||
|
|
||
| parser.add_argument('-f', '--file', type=str, |
There was a problem hiding this comment.
This must be an argument, not an option. If no argument is provided, the script should throw an error and terminate.
copernico
reviewed
Jul 23, 2024
scripts/bib2md.py
Outdated
Comment on lines
17
to
36
| try: | ||
| authors = entry['author'].split(' and ') | ||
| if len(authors) > 1: | ||
| authors[-1] = 'and ' + authors[-1] | ||
|
|
||
| authors_formatted = ', '.join([a.replace('\n', ' ').strip() for a in authors]) | ||
| title = entry['title'] | ||
| year = int(entry['year']) | ||
| venue = entry.get('journal') or entry.get('booktitle') or entry.get('archivePrefix') | ||
|
|
||
| if not venue: | ||
| id_unprocessed = "[" + entry.key + " - " + entry.entry_type + "]" | ||
| unprocessed_entries.append(id_unprocessed) | ||
| continue | ||
|
|
||
| formatted_entries.append((year, f"{authors_formatted}. {title}. {venue.value}. ({year}).")) | ||
|
|
||
| except KeyError as e: | ||
| print(f"One or more necessary fields {str(e)} not present in this BibTeX entry.") | ||
| continue |
There was a problem hiding this comment.
All this loop body should be a separate function that takes a single entry as input and returns a string as output.
copernico
reviewed
Jul 23, 2024
scripts/bib2md.py
Outdated
Comment on lines
55
to
58
| parser.add_argument('-ord', '--order', type=str, | ||
| choices=['asc', 'desc'], | ||
| help='here we set a sort order. We have the choice between "asc" and "desc"', | ||
| required=True) |
There was a problem hiding this comment.
this should not be required; if not provided, the order should be newest first
copernico
reviewed
Jul 23, 2024
scripts/bib2md.py
Outdated
Comment on lines
64
to
67
| apa_citations = format_simple(bibtex_str, args.order) | ||
| for citation in apa_citations: | ||
| print() | ||
| print(citation) |
There was a problem hiding this comment.
do not call this 'apa_citations', these might be formatted differently than APA
|
|
output md rf = output markdown reference
copernico
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output md rf = output markdown reference