Skip to content

Remove space before LIMIT clause #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove space before LIMIT clause #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlalchemy_hana/dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,12 @@ def default_from(self) -> str:
def limit_clause(self, select: Select[Any], **kw: Any) -> str:
text = ""
if select._limit_clause is not None:
text += "\n LIMIT " + self.process(select._limit_clause, **kw)
text += "\nLIMIT " + self.process(select._limit_clause, **kw)
if select._offset_clause is not None:
if select._limit_clause is None:
# 2147384648 is the max. no. of records per result set
# we can hardcode the value, because using a limit would lead to another cache key
text += "\n LIMIT 2147384648"
text += "\nLIMIT 2147384648"
text += " OFFSET " + self.process(select._offset_clause, **kw)
return text

Expand Down
Loading