Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert healpix workaround #193

Merged
merged 1 commit into from
Jun 23, 2024
Merged

revert healpix workaround #193

merged 1 commit into from
Jun 23, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Jun 23, 2024

Revert #188

@sroet sroet requested a review from McHaillet June 23, 2024 09:16
Copy link

File Coverage Missing
All files 87%
src/pytom_tm/correlation.py 85% 97-98 129
src/pytom_tm/entry_points.py 79% 28 105-122 220-265 354-372 490-507 940-951
src/pytom_tm/extract.py 75% 122-133 193-200 235-240 332-350
src/pytom_tm/io.py 80% 19 40 58 76 88 108-115 131-135 143 150 161 168 214-216 280 316-319 420-428 453
src/pytom_tm/mask.py 80% 72 90 100-101
src/pytom_tm/parallel.py 89% 14-15 89 100-101 107 170
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-395
src/pytom_tm/tmjob.py 97% 301-302 318 327-331 398 519 563
src/pytom_tm/utils.py 78% 17-19
src/pytom_tm/weights.py 96% 57 304-307 314 519 524 529

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against e129b5a

Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@McHaillet
Copy link
Collaborator

Should this update our deps and version number?

@sroet
Copy link
Collaborator Author

sroet commented Jun 23, 2024

Should this update our deps and version number?

Not sure what you mean by 'deps'?
version number should be fine as nothing changed in our code

@McHaillet
Copy link
Collaborator

Should this update our deps and version number?

Not sure what you mean by 'deps'? version number should be fine as nothing changed in our code

I meant the dependencies so that we only rely on healpix 2024.2

@sroet
Copy link
Collaborator Author

sroet commented Jun 23, 2024

Should this update our deps and version number?

Not sure what you mean by 'deps'? version number should be fine as nothing changed in our code

I meant the dependencies so that we only rely on healpix 2024.2

Nah, any new install should pull the new version. And the old version still works well as long as you downgrade numpy to 1.x

@McHaillet
Copy link
Collaborator

McHaillet commented Jun 23, 2024

Okay! I'll merge then!

@McHaillet McHaillet merged commit 609d6fb into main Jun 23, 2024
2 checks passed
@McHaillet McHaillet deleted the sroet-patch-1 branch June 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants