Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore tomo mask option #209

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Add ignore tomo mask option #209

merged 7 commits into from
Aug 7, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Aug 7, 2024 •
edited
Loading

closes #207

  • add code
  • update version
  • add tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

File Coverage Missing
All files 87% ✅
src/pytom_tm/correlation.py 85% ❌ 97-98 129
src/pytom_tm/entry_points.py 79% ❌ 28 111-128 231-276 379-398 531-549 996-1007
src/pytom_tm/extract.py 75% ❌ 122-133 198-205 242-247 339-357
src/pytom_tm/io.py 80% ❌ 19 40 58 76 88 108-115 131-135 143 150 161 168 214-216 280 316-319 420-428 453
src/pytom_tm/mask.py 80% ❌ 72 90 100-101
src/pytom_tm/parallel.py 89% ✅ 14-15 89 100-101 107 170
src/pytom_tm/plotting.py 16% ❌ 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-395
src/pytom_tm/tmjob.py 97% ✅ 301-302 318 327-331 398 519 563
src/pytom_tm/utils.py 78% ❌ 17-19
src/pytom_tm/weights.py 96% ✅ 57 304-307 314 519 524 529

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against e2fe751

@sroet sroet marked this pull request as ready for review August 7, 2024 13:10
@sroet sroet requested review from FridoF and McHaillet August 7, 2024 13:10
McHaillet
McHaillet requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks 👌 to me! Just noticed one typo.

tests/test_tmjob.py Outdated Show resolved Hide resolved
@sroet @McHaillet
Update tests/test_tmjob.py
e2fe751 
Co-authored-by: Marten Chaillet <[email protected]>
@sroet sroet requested a review from McHaillet August 7, 2024 13:35
McHaillet
McHaillet approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sroet sroet merged commit 0793404 into SBC-Utrecht:main Aug 7, 2024
2 checks passed
@sroet sroet deleted the add_ignore_tomo_mask_option branch August 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McHaillet McHaillet McHaillet approved these changes

@FridoF FridoF Awaiting requested review from FridoF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --ignore-tomogram-mask option to pytom_estimate_roc.py and pytom_ extract_candidates.py
2 participants
@sroet @McHaillet