Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed silent errors and added email checking #547

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Fixed silent errors and added email checking #547

merged 1 commit into from
Apr 21, 2024

Conversation

epadams
Copy link
Contributor

@epadams epadams commented Apr 21, 2024

  • Fixed silent error throwing for components mentioned here
  • Add email error checking

This was linked to issues Apr 21, 2024
Don't silently fail user actions #525
Closed
Incorrect email fails silently #545
Closed
@epadams epadams self-assigned this Apr 21, 2024
evan-scales
evan-scales approved these changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@evan-scales evan-scales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@epadams epadams marked this pull request as draft April 21, 2024 21:19
@epadams epadams marked this pull request as ready for review April 21, 2024 21:19
@epadams epadams merged commit 7c6fe9c into main Apr 21, 2024
2 checks passed
@epadams epadams deleted the SilentFail branch April 21, 2024 21:26
@evan-scales evan-scales mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-scales evan-scales evan-scales approved these changes

Assignees

@epadams epadams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect email fails silently Don't silently fail user actions
2 participants
@epadams @evan-scales