COMP: Update CI, Python packaging, and CMake 4.x compatibility#77
Closed
hjmjohnson wants to merge 4 commits into
Closed
COMP: Update CI, Python packaging, and CMake 4.x compatibility#77hjmjohnson wants to merge 4 commits into
hjmjohnson wants to merge 4 commits into
Conversation
✅ Deploy Preview for itk-wasm-cleaver-typescript-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hjmjohnson
force-pushed
the
update-to-v5.4.6
branch
4 times, most recently
from
7407a76 to
0d2a4c5
Compare
hjmjohnson
commented
Apr 15, 2026
- ITKRemoteModuleBuildTestPackageAction: sha ref → @v5.4.6 - actions/checkout: v3.5.3 → v5 - actions/setup-node: v4.0.0 → v4 (node 18 → 22) - actions/upload-artifact: v3 → v4 - cypress-io/github-action: v5 → v6 (already on branch) - ubuntu-22.04 → ubuntu-24.04 for wasm builds - Pin ITK wheel/python-package tags to v5.4.5
Update emscripten and wasi Docker images to match ITK 5.4.x. Bump itk-wasm devDependency to ^1.0.0-b.176.
Python 3.8 and 3.9 are EOL. ITK 5.4.x wheels target 3.10+.
The bundled googletest in SCIInstitute/Cleaver uses cmake_minimum_required < 3.5 which CMake >= 4.0 rejects. Disable BUILD_TESTING for the vendored lib unconditionally. Upstream fix tracked at SCIInstitute/Cleaver#130. The ITK module has its own CTest-based tests that are unaffected.
hjmjohnson
force-pushed
the
update-to-v5.4.6
branch
from
0d2a4c5 to
e6a55a1
Compare
hjmjohnson
changed the title
This was referenced Apr 15, 2026
Contributor
Author
|
Abandoning update to Cleaver. If this project becomes active again, revisit closed PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate all pending CI and packaging updates. Supersedes #63, #70, #72, #73, #74, #75.
4 commits: (1) CI workflows to latest actions + v5.4.6, (2) itk-wasm build images update, (3) Python 3.10+ and version 1.4.1, (4) CMake 4.x compat for vendored Cleaver lib testing (upstream fix: SCIInstitute/Cleaver#130).
Note: wasm build failure (itkOverrideGetNameOfClassMacro unknown) is pre-existing — Docker image uses an older ITK.