Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewScene bug report button #1997

Merged
merged 18 commits into from
Nov 7, 2019
Merged

Conversation

tarkpate
Copy link
Contributor

@tarkpate tarkpate commented Sep 27, 2019

Added a button in the view scene toolbar that saves a screenshot and pulls up an email template to send to @dcwhite.
Opens through the default mail client.
Requires qt5 to get system info.

Issues:
#1989

Edit:
Tested on MacOS 10.13 and Arch Linux
This won't pass travis until all builds are qt5

@dcwhite dcwhite self-assigned this Sep 30, 2019
@dcwhite dcwhite added the GUI label Sep 30, 2019
@dcwhite dcwhite added this to the 5.0-beta.X [Internal] milestone Sep 30, 2019
@@ -46,13 +46,13 @@ namespace SCIRun
public:
explicit Screenshot(QGLWidget *glwidget, QObject *parent = nullptr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't merge easily with https://github.com/SCIInstitute/SCIRun/pull/1979/files#diff-09b4cb29ce5bcc63aba5130a741d0f1a. I guess we can wait and see after #1979 is merged into qt5-dev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function for grabbing frame buffer is still the same.

@jessdtate
Copy link
Contributor

do we want this option on the main vs window? what about in the configure window?

@dcwhite
Copy link
Member

dcwhite commented Oct 29, 2019

@RubioJr9 This needs a proper merge from master--the method naming changed on the new opengl widget.

@tarkpate
Copy link
Contributor Author

It's merged properly now

@dcwhite
Copy link
Member

dcwhite commented Nov 1, 2019

@RubioJr9 will move the button to the new developer tab.

jessdtate
jessdtate previously approved these changes Nov 1, 2019
@jessdtate jessdtate self-requested a review November 1, 2019 21:25
// Temporarily save screenshot so that it can be sent over email
takeScreenshot();
QImage image = screenshotTaker_->getScreenshot();
QString location = QDir::homePath() % QLatin1String("/scirun5screenshots/scirun_bug.png");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubioJr9 I tested this and it works great. One request though. It would be nice to make unique screenshot files for people that test frequently. It's easy to append a timestamp to the file name and then copy that unique name here. Could you add that too? Thanks.

@dcwhite dcwhite merged commit a1bb3a0 into SCIInstitute:master Nov 7, 2019
@dcwhite
Copy link
Member

dcwhite commented Nov 7, 2019

@RubioJr9 I merged this one at long last and just created another issue to continue my requests (#2022)

@tarkpate tarkpate deleted the bug_report branch January 24, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants