-
Notifications
You must be signed in to change notification settings - Fork 35
Mesh distance symmetric #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nawazishkhan1-nk
wants to merge
5
commits into
master
Choose a base branch
from
mesh_distance_symmetric
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Mesh distance symmetric #2041
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9bd0e2d
symmetric point to cell clean method from prev branch
nawazishkhan1-nk 6bff57e
add new distance method in studio
nawazishkhan1-nk 6e04dbe
Merge branch 'master' into mesh_distance_symmetric
nawazishkhan1-nk 5774a01
Merge branch 'master' into mesh_distance_symmetric
akenmorris ef0ba1e
Merge branch 'master' into mesh_distance_symmetric
nawazishkhan1-nk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ | |
| .DS_* | ||
| .directory | ||
| .idea/ | ||
| .vscode/ | ||
|
|
||
| # PYC files | ||
| *.pyc | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -556,6 +556,42 @@ std::vector<Field> Mesh::distance(const Mesh& target, const DistanceMethod metho | |
| } | ||
| } break; | ||
|
|
||
| case SymmetricPointToCell: { | ||
| /* | ||
| referenceMesh (point) -> targetMesh (cell) (and get closestPoint) | ||
| referenceMesh (cell) -> targetMesh (closestPoint) | ||
| */ | ||
| auto targetCellLocator = vtkSmartPointer<vtkCellLocator>::New(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use the faster vtkStaticCellLocator |
||
| targetCellLocator->SetDataSet(target.poly_data_); | ||
| targetCellLocator->BuildLocator(); | ||
|
|
||
| auto refCellLocator = vtkSmartPointer<vtkCellLocator>::New(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. vtkStaticCellLocator as above |
||
| refCellLocator->SetDataSet(poly_data_); | ||
| refCellLocator->BuildLocator(); | ||
|
|
||
| double dist2_target, dist2_ref; | ||
| auto cell_target = vtkSmartPointer<vtkGenericCell>::New(); | ||
| auto cell_ref = vtkSmartPointer<vtkGenericCell>::New(); | ||
| vtkIdType cellId_target, cellId_ref; | ||
| int subId_target, subId_ref; | ||
| Point3 closestPoint_target, closestPoint_ref; | ||
|
|
||
|
|
||
| for (int i = 0; i < numPoints(); i++) { | ||
| poly_data_->GetPoint(i, currentPoint.GetDataPointer()); // ref point | ||
| // ref mesh point -> target mesh cell | ||
| targetCellLocator->FindClosestPoint(currentPoint.GetDataPointer(), closestPoint_target.GetDataPointer(), cell_target, cellId_target, | ||
| subId_target, dist2_target); | ||
| // target mesh closest point -> ref mesh cell | ||
| refCellLocator->FindClosestPoint(closestPoint_target.GetDataPointer(), closestPoint_ref.GetDataPointer(), cell_ref, cellId_ref, | ||
| subId_ref, dist2_ref); | ||
|
|
||
| ids->SetValue(i, cellId_target); | ||
| auto mean_sym_dist = (std::sqrt(dist2_target) + std::sqrt(dist2_ref))/2; | ||
| distance->SetValue(i, mean_sym_dist); | ||
| } | ||
| } break; | ||
|
|
||
| default: | ||
| throw std::invalid_argument("invalid distance method"); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a unit test for that case ?