Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export to CTS button #4680

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Add Export to CTS button #4680

merged 10 commits into from
Aug 27, 2024

Conversation

haneslinger
Copy link
Contributor

image

@haneslinger haneslinger added DO NOT MERGE Feature Add this label to new features. This will be reflected in the change log when generated. labels May 24, 2024
@RDmitchell
Copy link

just for my edification, what does "export to CTS" do?

@haneslinger
Copy link
Contributor Author

@laurenliz22 ESTP project requested the ability to export seeds buidingsync files into this very specific file format.

@haneslinger haneslinger changed the title Add progress bar Add to CTS button May 29, 2024
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I try to run this, I get a 500 on this call:
2024-05-29 13:54:34 ERROR "POST /api/v3/tax_lot_properties/export_to_cts/?organization_id=1 HTTP/1.1" 500 26363

File "/Users/kflemin/repos/seed/seed/views/v3/tax_lot_properties.py", line 697, in export_to_cts
building_sync_to_cts(list(building_files), Path(f.name))
File "/Users/kflemin/.pyenv/versions/newseedenv/lib/python3.9/site-packages/buildingsync_asset_extractor/cts/cts.py", line 66, in building_sync_to_cts
facility_by_id = aggregate_facilities(files)
File "/Users/kflemin/.pyenv/versions/newseedenv/lib/python3.9/site-packages/buildingsync_asset_extractor/cts/cts.py", line 36, in aggregate_facilities
file_etree = etree.parse(f)
File "src/lxml/etree.pyx", line 3538, in lxml.etree.parse
File "src/lxml/parser.pxi", line 1899, in lxml.etree._parseDocument
TypeError: cannot parse from 'dict'

I do know that this property has a buildingsync file that does not contain a facility ID...perhaps we just need to handle that error better?

UPDATE: I get the same error with files that have a facility ID in them...

@haneslinger
Copy link
Contributor Author

how odd, can we look at it together tomorrow?

@haneslinger haneslinger requested a review from kflemin May 30, 2024 22:17
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@kflemin kflemin merged commit d73cc6e into develop Aug 27, 2024
9 checks passed
@kflemin kflemin deleted the Add-to-CTS-button branch August 27, 2024 23:50
@axelstudios axelstudios changed the title Add to CTS button Add Export to CTS button Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants