Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drop trailing white spaces #284

Closed
wants to merge 1 commit into from

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Apr 26, 2024

Commit 6ff3d00 ("Add check for fcontext lines containing only spaces") added support for trailing white spaces in file context files together with some unit tests. These unit tests contain such trailing white spaces, which break the current CI due to the white space check via git diff-tree --check.

Drop the trailing spaces (together with the corresponding test code) to please the CI, hoping regressions will not happen.

Commit 6ff3d00 ("Add check for fcontext lines containing only spaces")
added support for trailing white spaces in file context files together
with some unit tests.  These unit tests contain such trailing white
spaces, which break the current CI due to the white space check via
`git diff-tree --check`.

Drop the trailing spaces (together with the corresponding test code) to
please the CI, hoping regressions will not happen.
@cgzones cgzones marked this pull request as ready for review April 26, 2024 17:16
@dburgener
Copy link
Member

I'm not really a fan of making changes that actually hurt just to please broken CI.

What about #285 as an alternative?

@cgzones cgzones closed this Apr 29, 2024
@cgzones cgzones deleted the trailing branch April 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants