tests: drop trailing white spaces #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6ff3d00 ("Add check for fcontext lines containing only spaces") added support for trailing white spaces in file context files together with some unit tests. These unit tests contain such trailing white spaces, which break the current CI due to the white space check via `git diff-tree --check`. Drop the trailing spaces (together with the corresponding test code) to please the CI, hoping regressions will not happen.
|
I'm not really a fan of making changes that actually hurt just to please broken CI. What about #285 as an alternative? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6ff3d00 ("Add check for fcontext lines containing only spaces") added support for trailing white spaces in file context files together with some unit tests. These unit tests contain such trailing white spaces, which break the current CI due to the white space check via
git diff-tree --check.Drop the trailing spaces (together with the corresponding test code) to please the CI, hoping regressions will not happen.