-
Notifications
You must be signed in to change notification settings - Fork 250
fix(schema): correct namespaced field type from string to boolean #3911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(schema): correct namespaced field type from string to boolean #3911
Conversation
Update cumulusci.jsonschema.json to fix the data type for the 'namespaced' field from string to boolean, which better reflects its intended usage.
Thanks for the contribution! Before we can merge this, we need @dipakparmar to sign the Salesforce Inc. Contributor License Agreement. |
@jstvz, is there anything else needed on this PR for the fix? Can we merge it? If not, please let me know. Thanks. |
@dipakparmar The tests are failing because the change needs to be in a different file. The To fix this, undo your changes to the JSON file. Instead, go to the ScratchOrg class in Finally, confirm that tests pass, then commit both the updated Python file and the new JSON file. |
Thanks @jstvz I have fixed it. All Test are passing: Test Summary
|
Update cumulusci.jsonschema.json to fix the data type for the 'namespaced' field from string to boolean, which better reflects its intended usage.
Fixes #3910