Remove PyFilesystem2 dependency #3923
Draft
+125
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `PyFilesystem2`. Importing `fs` emits a `pkg_resources` deprecation warning (see [pyfilesystem2#597](PyFilesystem/pyfilesystem2#597)). There are also open questions about the project’s maintenance status (see [pyfilesystem2#571](PyFilesystem/pyfilesystem2#571)). As far as I can tell, CumulusCI only relied on a small, local subset of functionality. That subset maps cleanly to Python’s standard library. This commit introduces a local-only `FSResource` and `open_fs_resource` implemented with `pathlib`, `os`, and `shutil`. `file://` URLs are supported for absolute and relative paths, and non-file schemes are rejected. All `fs` imports were removed and tests updated to expect `FileExistsError` instead of `fs.errors.DirectoryExists`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
PyFilesystem2. Importingfsemits apkg_resourcesdeprecation warning (seepyfilesystem2#597). There are also open questions about the project’s maintenance status (see
pyfilesystem2#571). As far as I can tell, CumulusCI only relied on a small, local subset of functionality. That subset maps cleanly to Python’s standard library.
This PR introduces a local-only
FSResourceandopen_fs_resourceimplemented withpathlib,os, andshutil.file://URLs are supported for absolute and relative paths, and non-file schemes are rejected. Allfsimports were removed and tests updated to expectFileExistsErrorinstead offs.errors.DirectoryExists.