Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AccessViolationException on KeyPress #254

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

nulldg
Copy link
Contributor

@nulldg nulldg commented May 30, 2024

The scancode field had been added to the key event in CSFML and this change was brought downstream in c68ed27. Master has been broken ever since because there was never any followup to update the binding.
It's a very simple bug and it's a severe one, and the exact cause has been known about for weeks, so why the fuck is this taking so long to address? Anyway, hope this helps.

Closes #245

@ChrisThrasher
Copy link
Member

Asking us why the fuck we’re so slow isn’t helping merge your PR faster. Please reconsider your language.

@nulldg
Copy link
Contributor Author

nulldg commented May 31, 2024

It's a genuine question, and it's not about this PR nor am I being critical of SFML.NET's overall development pace. The problem is that the lack of acknowledgement in #251 and to #245 implies this crash bug isn't taken seriously, and that it could make its way into the release of SFML.NET 2.6.0/2.6.1.

@eXpl0it3r
Copy link
Member

eXpl0it3r commented May 31, 2024

It's a genuine question [...] this crash bug isn't taken seriously

If you want to be taken seriously, you may want to use non-aggressive language and manage your emotional state.

SFML.Net 2.6.0 nor 2.6.1 have not been released and as such there's no guarantee on the completeness.
Additionally, if you use CSFML 2.6.0 or CSFML 2.6.1 with SFML.Net 2.5.0 or 2.5.1, you're missing some understanding of how SFML.Net depends on CSFML which depends on SFML and that the versions have to align.

Don't just press that update button, without understanding the impact.

And last but not least, nobody here owes anyone, anything. We're all working on this in our spare time and out of our own interest, not because someone has the "right" to a constantly up to date version.

@eXpl0it3r eXpl0it3r added the Feature New functionality or extending of an existing one label Jun 3, 2024
@eXpl0it3r eXpl0it3r merged commit b1cfedb into SFML:master Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality or extending of an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatch of KeyPress event throws a System.AccessViolationException
4 participants