Skip to content
This repository has been archived by the owner on May 29, 2022. It is now read-only.

Use relative includes for all GPSTk headers. #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamshapiro0
Copy link

Since GPSTk files don't obey the include/gpstk/ directory structure (e.g.,
polluting the top-level include path of any application that uses the library
since the application will be forced to add include/gpstk/ to its search path.

@adamshapiro0
Copy link
Author

@bparsons-sgl, is there a procedure for getting contributions merged in? Is there anyone who should be assigned to them or anything? Wasn't sure if you're the right person to ask but you seem to have made changes the most recently.

It looks like there are a bunch of pull requests going back all the way to 2014 fixing various things with RINEX and file handling. I merged the relevant ones by hand and the conflicts were easy to resolve with -X ours. That works for me for the time being, but it would be great to see them get merged in (including this one).

I tried running the unit tests as described in TESTING.md but they're failing on the current master with some swig errors. Everything else seems to be passing fine.

Thanks!

@masamitsutech
Copy link
Contributor

Hey @adamshapiro0 ,
As the maintainer of the GPSTk, I would be the person to assign.

Due to the nature of the Applied Research Labs at UT Austin and it's dependency on the stability of the GPSTk, we periodically collect and review external contributions to be added to the GPSTk. If the contributions are found to be of value and beneficial, then we will merge them internally and push those changes out with an external tag release back out to Github.

In the future, the review process will occur more frequently with each Pull Request, but we are still near the tail end of a long term internal refresh of the GPSTk.

We will be pushing a new release in the next few days, then begin reviewing the most recent/relevant pull requests and begin updating and moving forward to provide better service to our external developers. Expect to see a revamped website, CI/CD pipelines, and updated Wiki documentation as well.

Thanks for your interest in the GPSTk.

@adamshapiro0
Copy link
Author

@bparsons-sgl, thanks for the quick reply! That sounds great, and good timing too. I'll keep an eye out for the new release.

Since GPSTk files don't obey the include/gpstk/ directory structure (e.g.,
polluting the top-level include path of any application that uses the library
since the application will be forced to add include/gpstk/ to its search path.
@masamitsutech
Copy link
Contributor

This pull request will be reviewed for the next stable release.

This pull request will be closed if the change is accepted and merged into the toolkit. If any issues are found, we will report those here to be resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants