Preserve GitHub Project View tab order

[SIkebe]

GitHub exposes a POSITION ordering for Project Views, but live validation showed that it can remain different from the saved tab strip shown by GitHub. This change preserves source tab order through opt-in browser automation and uses the public API for the remaining View state.

Approach

• API-only export leaves tabPosition uncaptured because GraphQL POSITION is not a reliable saved-tab order.
• Browser-assisted export and verify read saved View tab href values in DOM order and store a nullable zero-based tabPosition without changing schema version 1.
• Import creates Views in snapshot order; API-only import warns that tab order requires browser automation.
• After browser-only View settings are applied, browser-assisted import calculates a minimum drag-and-drop plan using the longest increasing subsequence, supports overflow tabs, and verifies the resulting DOM order.
• API-only verify marks captured tab order as not verified; browser-assisted verify compares it.
• Extend deterministic, permutation, fixture, browser round-trip, and credentialed API coverage and update migration/E2E documentation.

Legacy snapshots without tabPosition remain loadable and skip order remediation.

Credentialed API validation

Follow-up validation requested during this PR also closes existing live-API gaps for pull-request item relinking, production import capability preflight, and connection-specific ProjectExporter pagination. PR relinking uses the canonical source fixture repository read-only and owns only its disposable target Project, so the existing credential contract remains unchanged.

Closes #50

[Copilot]

Pull request overview

Preserves GitHub Project View tab ordering through GraphQL snapshots, verification, and opt-in browser reordering.

Changes:

• Adds backward-compatible tabPosition snapshot support.
• Imports and verifies Views by tab position.
• Adds LIS-based browser drag planning, fixtures, tests, and documentation.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Ghpmv.Core.Tests/SnapshotTests.cs	Tests snapshot compatibility.
tests/Ghpmv.Core.Tests/ProjectViewImporterTests.cs	Tests position-aware import.
tests/Ghpmv.Core.Tests/ProjectVerifierTests.cs	Tests order verification.
tests/Ghpmv.Core.Tests/ProjectExporterTests.cs	Tests POSITION export.
tests/Ghpmv.Browser.Tests/ViewUiLogicTests.cs	Tests drag planning.
tests/Ghpmv.Browser.Tests/BrowserRoundTripTests.cs	Extends browser round-trip coverage.
src/Ghpmv.Core/Verify/ProjectVerifier.cs	Compares View order.
src/Ghpmv.Core/Snapshot/ProjectSnapshot.cs	Adds nullable tab position.
src/Ghpmv.Core/Import/ProjectViewImporter.cs	Orders imports and warns on mismatches.
src/Ghpmv.Core/Export/ProjectExporter.cs	Exports POSITION order.
src/Ghpmv.Core/Browser/ViewUiImporter.cs	Reorders tabs through Playwright.
src/Ghpmv.Core/Browser/Sel.cs	Adds draggable-tab selector.
src/Ghpmv.Core/Browser/FixtureUiSnapshotFactory.cs	Defines fixture tab order.
src/Ghpmv.Cli/Program.cs	Supplies GraphQL clients to browser importers.
docs/ui-maps/projects-ui-discovery.md	Documents tab drag behavior.
docs/MIGRATION_SCOPE.md	Marks browser-assisted order as supported.
docs/MANUAL_TEST_PLAN.md	Adds tab-order validation steps.
docs/BROWSER_AUTOMATION_PLAN.md	Documents ordering architecture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Ghpmv.Core/Export/ProjectExporter.cs:755

• This metadata query still truncates the views connection at 50, so a project with additional tabs silently omits them and assigns positions only to the first page. The connection has cursors, and the importer already paginates it in ProjectViewImporter.cs:429-479; export/verify should likewise fetch all POSITION-ordered pages before assigning TabPosition.

              views(first: 50, orderBy: { field: POSITION, direction: ASC }) {

src/Ghpmv.Core/Browser/ViewUiImporter.cs:925

• This read-back only sees the first 50 target tabs. On an updated project with enough pre-existing views, mapped source tabs can fall on a later page, causing the new reorder path to report an incomplete target and skip remediation even though all views exist. Paginate this POSITION-ordered connection, as ProjectViewImporter.FetchViewsAsync already does.

              views(first: 50, orderBy: { field: POSITION, direction: ASC }) {

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/Ghpmv.Core/Verify/ProjectVerifier.cs:782

• Browser-assisted verification still misses swaps between duplicate-name tabs whose API settings are identical but whose UI-only settings differ. The name sequences match, this positional check uses only ViewApiEquals, and the later UI comparison treats settings as an unordered multiset, so swapping tabs distinguished by Slice by, Field sum, or Roadmap settings produces no difference. Use combined API/UI identity when both sides have UI snapshots, while retaining API-only fallback when browser data is unavailable.

            var sourcePositions = sourceOrder.Where(view => string.Equals(view.Name, name, StringComparison.Ordinal));
            var targetPositions = targetOrder.Where(view => string.Equals(view.Name, name, StringComparison.Ordinal));
            if (!sourcePositions.Zip(targetPositions).All(pair => ViewApiEquals(pair.First, pair.Second)))

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Ghpmv.Core/Browser/ViewUiImporter.cs:164

• The tab-order phase has no recoverable exception boundary. Both its initial DOM read and final readback can throw PlaywrightException, TimeoutException, or InvalidOperationException; those exceptions currently escape EnrichAsync and abort the entire import instead of producing the warning promised for recoverable browser failures. Wrap this phase consistently with the per-view browser operations.

        await ReorderTabsAsync(
            page,
            snapshot,
            viewNumbers,
            cancellationToken).ConfigureAwait(false);

src/Ghpmv.Core/Browser/ViewUiImporter.cs:37

• This new public overload accepts a GitHubGraphQLClient but only null-checks it; the client has no effect and both constructors behave identically. That unnecessarily expands the public API and misleadingly implies GraphQL participates in browser View import. Remove the overload until the dependency is actually needed.

    public ViewUiImporter(BrowserSession session, GitHubGraphQLClient client)
        : this(session)
    {
        ArgumentNullException.ThrowIfNull(client);
    }

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/Ghpmv.Core/Browser/ViewUiImporter.cs:164

• The initial DOM read and the final read-back both run outside the recoverable exception handling in ApplyTabMovesAsync. If either selector/read fails with PlaywrightException, TimeoutException, or InvalidOperationException, browser-assisted import aborts instead of emitting the warning promised for recoverable tab-order failures. Catch those failures around the reorder stage so API/import work remains usable and the failure is reported.

        await ApplyTabOrderRecoverablyAsync(
            () => ReorderTabsAsync(
                page,
                snapshot,
                viewNumbers,

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

Suppressed comments (3)

tests/Ghpmv.Core.Tests/ProjectVerifierTests.cs:556

• This test name still attributes the order to GraphQL, but ProjectExporter now always leaves TabPosition null and only browser enrichment populates it. Rename the test so it describes comparing captured positions rather than implying API-only GraphQL verification.

    public void Graphql_view_position_order_is_compared_without_browser_automation()

docs/MANUAL_TEST_PLAN.md:702

• This expectation says an explicit tabPosition: null is saved, but snapshot serialization omits null properties (SnapshotJsonContext.cs:9). State that the property is omitted and interpreted as null so manual validation matches the actual file format.

| N-1 | `--enable-browser-automation` なしで export/import | API-only exportは`tabPosition: null`を保存する。browserで取得済みのtab orderを持つsnapshotのAPI-only importは未適用warning、API-only verifyは`NotVerified`として扱う。Views / Workflows UI-only項目もwarningまたは未移行として扱われる。 |

tests/Ghpmv.Integration.Tests/ItemImporterTests.cs:343

• The test keeps an identity repository mapping and therefore links the canonical source pull request into a project owned by the target organization; it does not relink to a target repository. Rename it to avoid claiming behavior the test does not exercise.

    public async Task Pull_request_item_is_relinked_to_the_target_repository_with_its_number_preserved()

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/Ghpmv.Core/Browser/ViewUiImporter.cs:37

• This public overload accepts a GitHubGraphQLClient but never stores or uses it, so it behaves exactly like the one-argument constructor while implying that the client affects tab reordering. Remove the overload to avoid exposing a misleading API surface (or give the client a concrete responsibility).

    public ViewUiImporter(BrowserSession session, GitHubGraphQLClient client)
        : this(session)
    {
        ArgumentNullException.ThrowIfNull(client);
    }

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.