Migrate field sums in grouped table and roadmap views

[SIkebe]

GitHub Projects exposes field sums only through the web UI, and ghpmv previously replayed them only for Board views. This extends browser-assisted migration so grouped Table and Roadmap views preserve the same complete field-sum selection.

What changed

• Apply field sums across Board and grouped Table/Roadmap layouts, including Count, multiple Number fields, and an empty selection.
• Read checked submenu entries directly so GitHub's truncated 1 more summary cannot lose values, and scope checkbox operations to avoid changing unrelated Roadmap display options.
• Expand the standard fixture and browser round-trip coverage for Table, Board, Roadmap, empty selections, and target drift.
• Integrate field-sum snapshot, View Match, UI observation, drift/repair, resource inventory, and cleanup consent into the existing ghpmv-e2e-validation browser E2E flow.
• Document the UI contract and repeatable manual validation procedure.

Validation

• Release build with warnings as errors
• 534 deterministic Core tests
• 108 deterministic Browser tests
• Disposable live GitHub Project round trip covering all three layouts and empty selection

Fixes: #62

[Copilot]

Pull request overview

Extends browser-assisted field-sum migration to grouped Table and Roadmap views.

Changes:

• Captures and applies complete field-sum selections.
• Expands fixtures and browser round-trip coverage.
• Updates E2E validation and documentation.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Ghpmv.Core/Browser/ViewUiExporter.cs	Reads checked field-sum entries.
src/Ghpmv.Core/Browser/ViewUiImporter.cs	Applies sums across supported layouts.
src/Ghpmv.Core/Browser/FixtureUiSnapshotFactory.cs	Adds grouped field-sum fixture views.
src/Ghpmv.Core/Fixtures/FixtureProjectBuilder.cs	Adds a second number field.
src/Ghpmv.Core/Snapshot/ProjectSnapshot.cs	Updates field-sum documentation.
tests/Ghpmv.Browser.Tests/ViewUiLogicTests.cs	Tests layout planning and verification.
tests/Ghpmv.Browser.Tests/BrowserRoundTripTests.cs	Expands browser E2E coverage.
.github/skills/ghpmv-e2e-validation/SKILL.md	Adds field-sum validation and cleanup flow.
docs/BROWSER_AUTOMATION_PLAN.md	Documents automation behavior.
docs/MANUAL_TEST_PLAN.md	Adds repeatable manual validation.
docs/MIGRATION_SCOPE.md	Records expanded support.
docs/ui-maps/projects-ui-discovery.md	Documents discovered UI behavior.

Suppressed comments (1)

.github/skills/ghpmv-e2e-validation/SKILL.md:951

• The target fallback also reuses an existing empty repository. Recording that repository as created makes the later consented cleanup delete a resource this run did not create; preserve it as pre-existing when the fallback is selected.

fixture seed 成功後、出力された target seed Project title / number / URL と `<target-org>/<target-repo>` を resource inventory に `created` として追加する。import 先 Project とは別 entry にする。

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Ghpmv.Core/Browser/ViewUiImporter.cs:774

• Disabled entries are added to available before this check, so a requested value that is present but disabled is treated as successfully applicable even though it is never clicked. The import then completes without a warning while leaving the target drifted; the inverse case (a disabled checked value that must be cleared) is also silent. Track entries whose current state cannot be changed separately and emit a property-specific warning when that state differs from desired.

            available.Add(name);
            if (string.Equals(await checkbox.GetAttributeAsync("aria-disabled").ConfigureAwait(false), "true", StringComparison.Ordinal))
            {
                continue;

docs/MANUAL_TEST_PLAN.md:375

• The manual fallback cannot recreate the fixture contract required by the new snapshot gate: it still describes only three tabs, gives the Table only a generic single Number sum, omits the Board sum, and never creates Fixture Empty Sums. If setup --fixture-ui fails and a user follows this path, Step 6 will always reject the fixture. Document the same four named views and exact selections used by FixtureUiSnapshotFactory.

  - group by Status
  - Field sum に `Fixture Number 2` を設定

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/skills/ghpmv-e2e-validation/SKILL.md:213

• A partially successful command is recorded and then the flow stops, but cleanup consent is only reached after a successful Step 10/repair. Failed fixture/import runs can therefore leave newly created Projects or repositories behind without ever offering the inventory-based cleanup path. Route failures after resource creation to cleanup consent (or an explicit retain decision) before ending the run.

追加の disposable target または native command は、fresh/existing、REST/browser、権限境界、destructive preview など、既存 command では別 code path を証明できない場合だけ許可する。追加理由と検証対象を明記し、resource inventory と cleanup に含める。同じ snapshot、mapping、target、verify command を再利用できる場合は複製しない。

.github/skills/ghpmv-e2e-validation/SKILL.md:219

• This cleanup branch requires deletion and read-back but does not provide the concrete Project/repository delete and verification commands; the manual plan only provides gh repo delete and says Projects may be deleted via UI or GraphQL. That leaves the agent to invent destructive operations, contrary to this skill's own “実行するコマンドを省略しない” rule at line 25. Add token/host-scoped commands and read-back checks for each inventory resource type.

|---|---|

.github/skills/ghpmv-e2e-validation/SKILL.md:1204

• Remove any existing drift report before running verify. Because a nonzero verify exit is expected here, an authentication/network failure on a rerun can otherwise be combined with a stale prior mismatch report and emit GHPMV_FIELD_SUM_DRIFT_DETECTED even though the current verify did not produce that report.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Suppressed comments (2)

docs/ui-maps/projects-ui-discovery.md:98

• This still says Field sum values can be read from the parent item without opening the submenu, but the newly documented 1 more truncation and the exporter change show that this loses selections. Describe reading all checked child entries instead so this UI contract does not contradict lines 36 and the implementation.

2. **Field sum は Board と grouped Table / Roadmap 共通のチェックボックスオーバーレイ**(`menuitemcheckbox`: "Count" + 数値フィールド名)。menuitem の accessible name は "Field sum: Count and Fixture Number" のようにラベル結合されるため値はメニューを開かず読める。Count は uncheck 可能。Table / Roadmap では未 grouping の間は項目自体が無い

docs/MANUAL_TEST_PLAN.md:503

• The exporter returns null when no Field sum checkbox is selected, and snapshot serialization omits null properties. Therefore an exported Fixture Empty Sums view will not contain the documented literal fieldSum=[]; document the omitted-field representation (or change the exporter to emit an empty list) so this manual assertion matches snapshot.json.

  - `Fixture Empty Sums`: `fieldSum=[]`

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/skills/ghpmv-e2e-validation/SKILL.md:361

• This deletion command cannot work for several supported credential paths. The classic PAT plans in this skill never request GitHub's required delete_repo scope, and the fine-grained PAT plan for a GEI target does not request repository Administration: write. As a result, cleanup after explicit consent will fail for repositories created on those paths. Provision a cleanup credential/permission before deletion (or add the required permission to the applicable token plans) and preflight it before offering repository cleanup.

    gh api @cleanupHostArguments --method DELETE 'repos/<owner>/<repository>'

.github/skills/ghpmv-e2e-validation/SKILL.md:1412

• The deliberate-drift checkpoint succeeds whenever the expected message is present, even if the report also contains unrelated View differences, warnings, or errors in other categories. That can mark a broken repair path as drift-detected, contrary to this flow's requirement to validate the exact intentional drift. Require exactly one non-informational difference—the expected View 1 field-sum mismatch—and reject any additional non-info differences.

$driftViewCategories = @($driftReport.categories | Where-Object category -eq 'View')
$fieldSumDifferences = @($driftReport.differences | Where-Object { $_.category -eq 'View' -and $_.message -match "view 'View 1': field sum mismatch" })
if ($driftViewCategories.Count -ne 1 -or $driftViewCategories[0].status -ne 'Mismatch' -or $fieldSumDifferences.Count -eq 0) {

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Suppressed comments (1)

docs/BROWSER_AUTOMATION_PLAN.md:317

• The updated standard-fixture views reference Fixture Number and Fixture Number 2, but the field inventory immediately above still documents the old Priority/Estimate/Start/End/Notes fixture. This makes the specification internally inconsistent with FixtureUiSnapshotFactory.cs:36-56 and the new view definitions. Update the inventory to list the actual Fixture* fields.

  1. "View 1" — grouped Table, filter, sort, Slice by, Field sum=[Count, Fixture Number, Fixture Number 2]

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

src/Ghpmv.Core/Browser/ViewUiExporter.cs:186

• This introduces a UI role selector directly in exporter logic, although Browser/Sel.cs:7-10 defines Sel as the single source of truth for Projects UI selectors. Move the checkbox/option overlay lookup into Sel and reuse it here (and in the importer) so a future role change cannot make export and import diverge.

        var checkboxes = overlay.GetByRole(AriaRole.Menuitemcheckbox);

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Ghpmv.Core/Browser/ViewUiExporter.cs:181

• ReadCheckedMenuValuesAsync now throws InvalidOperationException when the expected control or checkable entries are missing, but the per-view catch in EnrichAsync (lines 78–81) only handles Playwright/timeout failures. Either condition therefore aborts the entire export instead of leaving this View's UI uncaptured and emitting the documented warning. Include InvalidOperationException in that per-view catch so both throws are handled recoverably.

            if (required)
            {
                throw new InvalidOperationException($"'{label}' control is not available for this grouped view");

src/Ghpmv.Core/Browser/ViewUiImporter.cs:737

• If the child-menu selector returns zero options and the desired selection is empty, the missing-value loop emits no warning, so an unavailable/broken Field sum submenu is incorrectly treated as a successful clear. Since every valid Field sum submenu contains at least Count, report the empty available set before processing individual missing values.

            foreach (var value in values.Where(value => !result.Available.Contains(value)))
            {
                _warnings.Add($"view '{viewName}': {label} value '{value}' is not available on the target");
            }

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/skills/ghpmv-e2e-validation/SKILL.md:1035

• This gate treats FieldSum as ordered, although field sums are a selection set (the importer uses a HashSet and ProjectVerifier.UiListEquals sorts both sides). An existing equivalent fixture can therefore be rejected solely because GitHub returns the checked fields in a different menu/field order. Compare sorted values while retaining the existing exact membership check.

    if ([string]::Join("`0", [string[]]$actualFieldSum) -ne [string]::Join("`0", [string[]]$expected.FieldSum)) {
        Stop-FieldSumSnapshotCheck "View '$($expected.Name)' FieldSum mismatch: expected [$($expected.FieldSum -join ', ')], actual [$($actualFieldSum -join ', ')]."
        return

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.