Preserve Board column limits

[SIkebe]

GitHub Projects does not expose per-column Board limits through its public APIs, so migrations previously lost this view-specific state. This adds browser-assisted round-trip support while keeping API-only and legacy snapshots non-destructive.

• Persist configured limits using logical field and Single-select option or Iteration identities, never source node IDs.
• Treat captured limits as complete-set state so import can set configured limits and clear removed ones, with read-back retries and precise warnings.
• Verify changed, missing, unexpected, and uncaptured limits, including duplicate-named Views.
• Extend standard fixtures, drift/repair coverage, documentation, and the E2E validation workflow for numeric, unlimited, and over-limit rendering.

The deterministic Release build and Core/Browser test suites pass. Live Browser E2E remains credential-gated and was not run because the required browser state and test token were unavailable.

Fixes: #66

[Copilot]

🟡 Changes recommended

The rendering command currently cannot resolve either Board, and duplicate-view verification can miss unavailable limit captures.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds browser-assisted migration of Board column limits using logical field/value identities.

Changes:

• Adds snapshot, export, import, and verification support for column limits.
• Extends fixtures, browser E2E validation, drift repair, and documentation.
• Preserves API-only and legacy snapshot behavior.

File summaries

File	Description
src/Ghpmv.Core/Snapshot/ProjectSnapshot.cs	Defines the limit snapshot model.
src/Ghpmv.Core/Browser/BoardColumnLimitUi.cs	Reads, applies, and clears limits.
src/Ghpmv.Core/Browser/BoardColumnLimitObserver.cs	Validates rendered fixture limits.
src/Ghpmv.Core/Browser/ViewUiExporter.cs	Captures limits during export.
src/Ghpmv.Core/Browser/ViewUiImporter.cs	Validates and imports complete limit sets.
src/Ghpmv.Core/Browser/Sel.cs	Centralizes Board-limit selectors.
src/Ghpmv.Core/Browser/FixtureUiSnapshotFactory.cs	Adds Board fixtures and drift state.
src/Ghpmv.Core/Verify/ProjectVerifier.cs	Compares captured limits.
src/Ghpmv.Cli/Program.cs	Integrates rendering and drift checks.
tests/Ghpmv.Core.Tests/ProjectVerifierTests.cs	Tests verification semantics.
tests/Ghpmv.Core.Tests/FixtureProjectBuilderTests.cs	Checks over-limit fixture counts.
tests/Ghpmv.Browser.Tests/ViewUiSnapshotSerializationTests.cs	Tests serialization compatibility.
tests/Ghpmv.Browser.Tests/ViewUiLogicTests.cs	Tests parsing, validation, and drift.
tests/Ghpmv.Browser.Tests/BrowserRoundTripTests.cs	Extends shared browser E2E coverage.
docs/ui-maps/projects-ui-discovery.md	Documents the UI contract.
docs/MIGRATION_SCOPE.md	Records migration support.
docs/MANUAL_TEST_PLAN.md	Adds manual validation checkpoints.
docs/BROWSER_AUTOMATION_PLAN.md	Documents browser-only architecture.
.github/skills/ghpmv-e2e-validation/SKILL.md	Extends the shared E2E workflow.

Review details

• Files reviewed: 19/19 changed files
• Comments generated: 4
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Missing-target behavior lacks the required coverage, and two fixture-contract documents remain inconsistent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 19/19 changed files
• Comments generated: 3
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Reconciliation can write incorrect limits after prerequisite or identity validation failures, and duplicate-View verification is order-dependent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/Ghpmv.Core/Browser/BoardColumnLimitUi.cs:80

• This plan does not fail closed for malformed captured identities even though preflight only records warnings. A wrong FieldName is filtered out here and then every displayed limit is cleared; an Iteration identity on a Single-select field (or an entry with both identities) is keyed by its text and can update that same-named target column. Validate every desired entry against the resolved field and return no targets on any warning before reconciling the complete set.

        var desiredByName = desiredLimits
            .Where(limit => string.Equals(limit.FieldName, field.Name, StringComparison.Ordinal))
            .ToDictionary(GetValueName, StringComparer.Ordinal);

• Files reviewed: 19/19 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The credential-gated browser E2E was not run, leaving the new UI-dependent selectors and persistence behavior unverified against GitHub.

Review details

• Files reviewed: 19/19 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Snapshot gates, drift assertions, duplicate-set verification, and narrow-width tab dragging have unresolved correctness issues.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (3)

Previously missed (1) — in code that hasn't changed since the last review.

.github/skills/ghpmv-e2e-validation/SKILL.md:1884

• Counting any two Board-limit differences does not prove the deliberate drift identified Alpha as changed from 1 to 5 and Beta as cleared. Two mismatches for different columns or values would still emit GHPMV_BOARD_LIMIT_DRIFT_DETECTED, contrary to the workflow's exact-column checkpoint. Filter against the two expected full messages before applying the count check.

$boardLimitDifferences = @($driftReport.differences | Where-Object { $_.category -eq 'View' -and $_.message -match "view 'Fixture Board': Board limit mismatch" })

.github/skills/ghpmv-e2e-validation/SKILL.md:1135

• This snapshot gate can still mark the Board-limit contract as matched when the Board uses the wrong verticalGroupByFields value or when the declared unlimited values (Gamma, Sprint 2, Sprint 3) do not exist in the corresponding field. In those cases the later observer/import fails only after target preparation, despite this step being the pre-target hard gate. Validate each Board's single column-by field and the complete Single-select/Iteration value set before emitting GHPMV_BOARD_LIMIT_SNAPSHOT_MATCH.

    $actualLimits = @($views[0].ui.boardColumnLimits)
    if ($actualLimits.Count -ne $expectedView.Count) {
        Stop-FieldSumSnapshotCheck "View '$($expectedView.Name)' boardColumnLimits must contain exactly $($expectedView.Count) configured limits; found $($actualLimits.Count)."
        return
    }

src/Ghpmv.Core/Verify/ProjectVerifier.cs:1259

• This per-entry lookup is not one-to-one, so duplicate logical entries can falsely verify as a complete-set match: source [Alpha=1, Alpha=1] versus target [Alpha=1] reuses the same target for both source entries, and the inverse also passes the second loop. Since duplicate identities are explicitly treated as malformed during import, consume matched target entries (or use the existing multiset matcher) so verify cannot report Match for unequal captured sets.

        foreach (var sourceLimit in source)
        {
            var targetLimit = target.FirstOrDefault(candidate => SameBoardColumn(sourceLimit, candidate));
            if (targetLimit is null)

• Files reviewed: 19/19 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The Step 6 snapshot gate can accept fixtures that omit the required unlimited columns.

Review details

Suppressed comments (1)

.github/skills/ghpmv-e2e-validation/SKILL.md:1123

• The Step 6 gate validates only the four configured entries. It never proves that Gamma and Sprint 2/3 exist as unlimited columns, so an existing fixture containing only Alpha/Beta and Sprint 0/1 still emits GHPMV_BOARD_LIMIT_SNAPSHOT_MATCH and proceeds to target creation despite violating the declared fixture contract. Validate the Board column fields' option/iteration sets (including these unlimited identities) before emitting the marker.

$expectedBoardLimits = @(
    [pscustomobject]@{ View = 'Fixture Board'; Field = 'Fixture Select'; Property = 'singleSelectOptionName'; Value = 'Alpha'; Limit = 1 },
    [pscustomobject]@{ View = 'Fixture Board'; Field = 'Fixture Select'; Property = 'singleSelectOptionName'; Value = 'Beta'; Limit = 2 },
    [pscustomobject]@{ View = 'Fixture Iteration Board'; Field = 'Fixture Sprint'; Property = 'iterationTitle'; Value = 'Sprint 0'; Limit = 1 },
    [pscustomobject]@{ View = 'Fixture Iteration Board'; Field = 'Fixture Sprint'; Property = 'iterationTitle'; Value = 'Sprint 1'; Limit = 3 }

• Files reviewed: 19/19 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Hidden Board columns can be omitted or left stale while complete-set capture and reconciliation report success.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/Ghpmv.Core/Browser/BoardColumnLimitUi.cs:151

• Complete-set reconciliation only creates targets for displayed columns. If a target column is hidden and the source expects it to be unlimited, it is absent from both desiredByName and displayedColumnNames, so its stale target limit is neither cleared nor warned about; the subsequent read-back omits it as well and can report success. Reconcile all logical columns, or fail closed when any target column is hidden/unavailable.

        var targets = displayedColumnNames
            .Where(columnName => ValueExists(field, columnName))
            .Select(columnName => new ReconciliationTarget(
                columnName,
                desiredByName.TryGetValue(columnName, out var configured)
                    ? configured.Limit
                    : null))

• Files reviewed: 19/19 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

The new per-column menu loops omit the repository’s required UI-operation pacing, risking browser automation races.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/Ghpmv.Core/Browser/BoardColumnLimitUi.cs:305

• This write path likewise skips the documented 300 ms delay between consecutive UI interactions (docs/BROWSER_AUTOMATION_PLAN.md:116). Since reconciliation visits every column serially, immediate action/menu/fill/save operations can race GitHub's overlays and violate the repository's UI pacing policy; apply the standard delay throughout this sequence.

        await Sel.BoardColumnActionsButton(page, columnName).ClickAsync().ConfigureAwait(false);
        var item = Sel.BoardColumnLimitMenuItem(page);
        await item.WaitForAsync().ConfigureAwait(false);
        await item.ClickAsync().ConfigureAwait(false);

• Files reviewed: 19/19 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The manual procedure and UI discovery guidance remain inconsistent with the newly documented drift and sort-field behavior.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

docs/MANUAL_TEST_PLAN.md:708

• The new checklist requires Board-limit drift and repair, but the numbered procedure above still tells the operator to expect only seven mismatches (defaults, field sum, and Roadmap dates) and says the re-import restores only Field sum/Roadmap state. A correct run now produces two additional Board-limit mismatches, so following that procedure rejects the expected report and never records Board-limit repair. Update steps 8–11 to include both Board mismatches and Board-limit restoration.

- [ ] targetで`Fixture Board`のAlpha上限を変更しBeta上限をclearすると、verifyが両logical columnを区別して検出する。
- [ ] 同じsnapshot/targetへ再importすると上限が復元され、Item categoryには移動・field value変更がない。

src/Ghpmv.Core/Browser/ViewUiImporter.cs:1628

• This newly unchecks a temporarily shown sort field, but docs/ui-maps/projects-ui-discovery.md:140 still documents the opposite importer contract: the sort field is retained in the desired set specifically to prevent unchecking it. Since the test makes this behavior intentional, update the UI discovery record to explain that hiding the virtual column preserves the sort; otherwise future selector work will follow contradictory guidance.

        return sortFieldWasTemporarilyShown
            && !view.VisibleFields.Contains(sortField, StringComparer.Ordinal);

• Files reviewed: 19/19 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

The Step 6 snapshot gate can accept fixtures missing unlimited columns or the required over-limit item state.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

.github/skills/ghpmv-e2e-validation/SKILL.md:1123

• The Step 6 gate validates only the four configured entries. An existing fixture with no Gamma/Sprint 2/Sprint 3 values, or with only one item in each limit-1 column, still emits GHPMV_BOARD_LIMIT_SNAPSHOT_MATCH; the missing unlimited and over-limit prerequisites are discovered only after target resources have been created. Extend this early gate to assert those logical values exist and that the snapshot has more than one item assigned to Alpha and Sprint 0.

$expectedBoardLimits = @(
    [pscustomobject]@{ View = 'Fixture Board'; Field = 'Fixture Select'; Property = 'singleSelectOptionName'; Value = 'Alpha'; Limit = 1 },
    [pscustomobject]@{ View = 'Fixture Board'; Field = 'Fixture Select'; Property = 'singleSelectOptionName'; Value = 'Beta'; Limit = 2 },
    [pscustomobject]@{ View = 'Fixture Iteration Board'; Field = 'Fixture Sprint'; Property = 'iterationTitle'; Value = 'Sprint 0'; Limit = 1 },
    [pscustomobject]@{ View = 'Fixture Iteration Board'; Field = 'Fixture Sprint'; Property = 'iterationTitle'; Value = 'Sprint 1'; Limit = 3 }

• Files reviewed: 19/19 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The credential-gated live browser E2E was not run, leaving the new undocumented UI interactions without final environment validation.

Review details

• Files reviewed: 19/19 changed files
• Comments generated: 0 new
• Review effort level: Balanced