feat: 영상 목록 hasUnreadFeedback 구현 (#121) - #124
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough영상별 미읽음 피드백 조회가 다중 ID 기반의 Changes미읽음 피드백 흐름
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant VideoService
participant NotificationService
participant NotificationRepository
participant VideoResponse
VideoService->>NotificationService: 영상 ID 목록 전달
NotificationService->>NotificationRepository: 영상별 미읽음 알림 그룹 조회
NotificationRepository-->>NotificationService: 영상별 개수 반환
NotificationService-->>VideoService: Map<Long, Integer> 반환
VideoService->>VideoResponse: hasUnreadFeedback 전달
VideoResponse-->>VideoService: 영상 목록 응답 생성
Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/slatto/domain/notification/repository/NotificationRepository.java`:
- Around line 127-143: Update findUnreadGroupedNotificationCounts in
NotificationRepository so the query selects targetId alongside the grouped
count, because NotificationService.getUnreadVideoFeedbackCounts reads each row
as a (targetId, count) Object[] pair. Keep the existing filters and grouping
logic, but change the projection to return one tuple per targetId with the count
in the second position so row[0] and row[1] remain valid.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ce838f27-87f5-455c-8743-7ec91a55a4f1
📒 Files selected for processing (4)
src/main/java/com/slatto/domain/notification/repository/NotificationRepository.javasrc/main/java/com/slatto/domain/notification/service/NotificationService.javasrc/main/java/com/slatto/domain/video/dto/response/VideoResponse.javasrc/main/java/com/slatto/domain/video/service/VideoService.java
🔗 관련 이슈 (Related Issue)
Closes #121
📝 작업 내용
unreadCommentCount를hasUnreadFeedback으로 변경했습니다.hasUnreadFeedback=true를 반환하도록 적용했습니다.unreadCommentCount필드를 제거했습니다.✅ PR 체크리스트
Summary by CodeRabbit