Support for DEXA with ImageComments tag containing XML #7
Conversation
because Lunar iDXA writes XML into that field which may include EXAM_DATE that needs to be redacted.
use the 'redact' keys from sr_keys_to_extract
use a variable so that it can be changed in future (should never need to be more than 8 I think, depends on how many extra linefeeds appear between sections)
…SemEHR reconstructs the text from its working_fields so that its offsets match ours better
There was a problem hiding this comment.
Hi, apologies for not reviewing this until now.
This is a necessary change to support DEXA extractions, and the PR looks good overall. My only suggested change is that we make this configurable somehow. It would be helpful to have the ability to enable/disable this if we decide this is a "safe" change for some SR extractions only.
and also add other Comments tags, also off by default
and enhance all the tests to test ImageComments
|
It is now optional, and the default is off, so ImageComments is not extracted by default. The option is not exposed in the command line tools (yet) - not quite sure how exactly you want want to change configurable things like this on a per-extraction basis. (Also it's a little bit more complex because the tools can read from MongoDB as well as from DICOM files and the two have different internal representations of the SR structure so need different code to read). |
ImageComments needs to be extracted so that it can be redacted.
Resolves #6
but please see all the comments in that issue to understand the implications.