fix: oracle ops config and error hygiene - #628
Open
goldandrew wants to merge 2 commits into
Open
Conversation
- Add configurable SET_PRICES_TX_FEE / KEEPER_TX_FEE env vars, replacing
hardcoded transaction inclusion fees in the keeper loop.
- Fix config.rs env-parsing blocks that used bare `{}` blocks with `return`/`?`
targeting the wrong Result type (EnvErrors vs EnvError), which failed to
compile; wrap them in closures so early returns resolve correctly.
- Fix ConfigError -> EnvError conversion for price_feed loading.
- Carry truncated HTTP response bodies into Binance/Coinbase/Pyth/RPC error
variants for better diagnostics.
- De-duplicate keeper low-balance log spam: only emit `error!` on the
transition into a below-minimum state, `debug!` while it persists, and
`info!` on recovery.
- Fix build_spot_price_url ignoring the caller's base_url, which caused
Binance wiremock tests to hit the live API instead of the mock server.
- Remove dead/duplicated code in binance.rs and signing.rs.
- Add MIT license field to oracle/shared-config crates and LICENSE file.
|
@goldandrew Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
goldandrew
force-pushed
the
fix/oracle-ops-and-error-hygiene
branch
from
July 27, 2026 12:32
d3f5d7f to
83d83f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET_PRICES_TX_FEE/KEEPER_TX_FEEenv vars, replacing hardcoded transaction inclusion fees in the keeper loop.config.rsenv-parsing blocks whosereturn/?targeted the wrong error type (EnvErrorsvsEnvError), which failed to compile.error!only on transition into low-balance,debug!while sustained,info!on recovery.build_spot_price_urlignoring the caller'sbase_url, which caused Binance wiremock tests to silently hit the live API instead of the mock server.binance.rsandsigning.rs.oracle/shared-configcrates and aLICENSEfile.Test plan
cargo build --workspacecargo test --workspacecloses #576
closes #574
closes #567
closes #568