Feature/issue 358/profile pic in friends list#445
Open
wolfie7679 wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
wolfie7679
commented
Mar 28, 2025
wolfie7679
commented
- Added profilePicture in DTO
- modified tests
- Part 2 of 2
- Modified tests -modified DTO + model
- Added missing url in tests
wolfie7679
requested review from
DanDuguay,
Ziadsharkos,
wade3hamati and
walidoow
Ziadsharkos
reviewed
Mar 29, 2025
Contributor
Ziadsharkos
left a comment
Ziadsharkos
left a comment
There was a problem hiding this comment.
Could we not just return the user profile of the friend instead of the just that profile pic of the friend?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.