Creating New Chatrooms without chat functionality yet.#458
Closed
Creating New Chatrooms without chat functionality yet.#458
Conversation
Closed
NicolasChelico
approved these changes
Apr 1, 2025
Contributor
NicolasChelico
left a comment
There was a problem hiding this comment.
lgtm , core feature here
Contributor
Author
|
there's a bug, when a room is created and no message is sent, there's bug fetching the room information because the message array is empty |
…nge later due to incompatibility with react native expo
…scribing to a specific topic working
…ute to chatroom yet
- changes to createUserChatroom are now caushing 400 (but over postamn too)
…nds, no unread ui updates yet
29c0b02 to
569c266
Compare
Contributor
Author
|
addressed and merged in #471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #365
This PR introduces creating a chat feature with the following functionalities:
NOTES BEFORE REVIEW:
react-native-keyboard-controllerlibrary which is native and doesn't work with Expo Go so please ignore this error as it is not yet used in the implementation of the chat.Test steps:
to start a chat from the user profile with an individual
to start a chat from the chat tab
creators of a chatroom can delete it*
members can leave it.*