Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 이미지 업로드 #61

Merged
merged 4 commits into from
Jul 23, 2023
Merged

feat: 이미지 업로드 #61

merged 4 commits into from
Jul 23, 2023

Conversation

onpyeong
Copy link
Member

📌 관련 이슈

close #60

✨ 과제 내용

  • 북토크 생성 시 이미지 업로드
  • 공간 생성 시 이미지 업로드
  • 요거 아직은 머지 안해도 될 것 같긴 합니다!

@onpyeong onpyeong requested a review from dong2ast July 19, 2023 15:37
@onpyeong onpyeong self-assigned this Jul 19, 2023
Copy link
Collaborator

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 확인했고, 특별히 이상한 점은 없는 것 같습니다~

@@ -24,7 +27,7 @@ public class BooktalkController {

@PostMapping //북토크 생성
@ResponseStatus(HttpStatus.CREATED)
public ApiResponseDto<BooktalkCreateResponseDto> createBooktalk(@Valid @RequestBody BooktalkRequestDto booktalkRequestDto) {
public ApiResponseDto<BooktalkCreateResponseDto> createBooktalk(@Valid @ModelAttribute BooktalkRequestDto booktalkRequestDto) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 ModelAttribute 였군여 오랜만에 보는 것 같습니다

@dong2ast dong2ast merged commit 889e825 into main Jul 23, 2023
1 check passed
@dong2ast dong2ast deleted the feat/#60-image-upload branch July 23, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 이미지 업로드
2 participants