Open
Conversation
kangsiwoo
commented
Aug 8, 2024
Contributor
Author
There was a problem hiding this comment.
Review 1
메인이 되는 각 파일에는 역할마다 이름이 있습니다.
이는 어떤 파일이 가장 중요한지, root 파일인지 알려줍니다.
- js에는 app,
- html에는 index,
- css에는 style.css
지금같은 경우 css와 html은 해당 이름으로 변경해야 하지만 js같은 경우 역할을 바로 확인할 수 있게 이름을 변경해야 합니다.
과제1/js/headHover.js
Outdated
Comment on lines
+1
to
+28
Contributor
Author
There was a problem hiding this comment.
Review 2
반복적인 기능같은경우 id의 이름을 파라미터로 받아 유동적으로 코드를 작성하는게 좋습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.