feat: add localnode dns cache #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+36
to
+46
| ports: | ||
| - name: dns | ||
| port: 53 | ||
| protocol: UDP | ||
| targetPort: 53 | ||
| - name: dns-tcp | ||
| port: 53 | ||
| protocol: TCP | ||
| targetPort: 53 | ||
| selector: | ||
| k8s-app: kube-dns |
Check warning
Code scanning / Trivy
User Pods should not be placed in kube-system namespace Medium
| forward . __PILLAR__UPSTREAM__SERVERS__ | ||
| prometheus :9253 | ||
| } | ||
| --- |
Check warning
Code scanning / Trivy
Seccomp policies disabled Medium
| forward . __PILLAR__UPSTREAM__SERVERS__ | ||
| prometheus :9253 | ||
| } | ||
| --- |
Check failure
Code scanning / Trivy
Prevent binding to privileged ports High
Comment on lines
114
to
209
| updateStrategy: | ||
| rollingUpdate: | ||
| maxUnavailable: 10% | ||
| selector: | ||
| matchLabels: | ||
| k8s-app: node-local-dns | ||
| template: | ||
| metadata: | ||
| labels: | ||
| k8s-app: node-local-dns | ||
| annotations: | ||
| prometheus.io/port: "9253" | ||
| prometheus.io/scrape: "true" | ||
| spec: | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux | ||
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - arm64 | ||
| - key: eks.amazonaws.com/compute-type | ||
| operator: NotIn | ||
| values: | ||
| - fargate | ||
| - auto | ||
| priorityClassName: system-node-critical | ||
| serviceAccountName: node-local-dns | ||
| hostNetwork: true | ||
| dnsPolicy: Default # Don't use cluster DNS. | ||
| tolerations: | ||
| - key: "CriticalAddonsOnly" | ||
| operator: "Exists" | ||
| - effect: "NoExecute" | ||
| operator: "Exists" | ||
| - effect: "NoSchedule" | ||
| operator: "Exists" | ||
| containers: | ||
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns | ||
| volumes: | ||
| - name: xtables-lock | ||
| hostPath: | ||
| path: /run/xtables.lock | ||
| type: FileOrCreate | ||
| - name: kube-dns-config | ||
| configMap: | ||
| name: kube-dns | ||
| optional: true | ||
| - name: config-volume | ||
| configMap: | ||
| name: node-local-dns | ||
| items: | ||
| - key: Corefile | ||
| path: Corefile.base |
Check failure
Code scanning / Trivy
Access to host network High
Comment on lines
114
to
209
| updateStrategy: | ||
| rollingUpdate: | ||
| maxUnavailable: 10% | ||
| selector: | ||
| matchLabels: | ||
| k8s-app: node-local-dns | ||
| template: | ||
| metadata: | ||
| labels: | ||
| k8s-app: node-local-dns | ||
| annotations: | ||
| prometheus.io/port: "9253" | ||
| prometheus.io/scrape: "true" | ||
| spec: | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux | ||
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - arm64 | ||
| - key: eks.amazonaws.com/compute-type | ||
| operator: NotIn | ||
| values: | ||
| - fargate | ||
| - auto | ||
| priorityClassName: system-node-critical | ||
| serviceAccountName: node-local-dns | ||
| hostNetwork: true | ||
| dnsPolicy: Default # Don't use cluster DNS. | ||
| tolerations: | ||
| - key: "CriticalAddonsOnly" | ||
| operator: "Exists" | ||
| - effect: "NoExecute" | ||
| operator: "Exists" | ||
| - effect: "NoSchedule" | ||
| operator: "Exists" | ||
| containers: | ||
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns | ||
| volumes: | ||
| - name: xtables-lock | ||
| hostPath: | ||
| path: /run/xtables.lock | ||
| type: FileOrCreate | ||
| - name: kube-dns-config | ||
| configMap: | ||
| name: kube-dns | ||
| optional: true | ||
| - name: config-volume | ||
| configMap: | ||
| name: node-local-dns | ||
| items: | ||
| - key: Corefile | ||
| path: Corefile.base |
Check warning
Code scanning / Trivy
hostPath volumes mounted Medium
Comment on lines
159
to
194
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns |
Check notice
Code scanning / Trivy
Runs with GID <= 10000 Low
Comment on lines
159
to
194
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns |
Check warning
Code scanning / Trivy
Specific capabilities added Medium
Comment on lines
159
to
194
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns |
Check notice
Code scanning / Trivy
Runtime/Default Seccomp profile not set Low
Comment on lines
159
to
194
| - name: node-cache | ||
| image: registry.k8s.io/dns/k8s-dns-node-cache:${tag} | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 5Mi | ||
| args: [ "-localip", "${PILLAR__LOCAL__DNS},${PILLAR__DNS__SERVER}", "-conf", "/etc/Corefile", "-upstreamsvc", "kube-dns-upstream" ] | ||
| securityContext: | ||
| capabilities: | ||
| add: | ||
| - NET_ADMIN | ||
| ports: | ||
| - containerPort: 53 | ||
| name: dns | ||
| protocol: UDP | ||
| - containerPort: 53 | ||
| name: dns-tcp | ||
| protocol: TCP | ||
| - containerPort: 9253 | ||
| name: metrics | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| host: ${PILLAR__LOCAL__DNS} | ||
| path: /health | ||
| port: 8080 | ||
| initialDelaySeconds: 60 | ||
| timeoutSeconds: 5 | ||
| volumeMounts: | ||
| - mountPath: /run/xtables.lock | ||
| name: xtables-lock | ||
| readOnly: false | ||
| - name: config-volume | ||
| mountPath: /etc/coredns | ||
| - name: kube-dns-config | ||
| mountPath: /etc/kube-dns |
Check notice
Code scanning / Trivy
Container capabilities must only include NET_BIND_SERVICE Low
Comment on lines
+224
to
+230
| clusterIP: None | ||
| ports: | ||
| - name: metrics | ||
| port: 9253 | ||
| targetPort: 9253 | ||
| selector: | ||
| k8s-app: node-local-dns |
Check warning
Code scanning / Trivy
User Pods should not be placed in kube-system namespace Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.