fix: resolve merge conflicts in helpers.ts causing timezone display bugs - #78
Merged
Muyideen-js merged 3 commits intoJul 30, 2026
Merged
Conversation
Remove duplicate formatDate/formatTime/timeAgo definitions. All timestamp functions now consistently use Intl.DateTimeFormat with viewer locale+timezone. Fix explorerUrl merge corruption. Clean up markets page duplicate imports. Closes SPaulse-Org#70, SPaulse-Org#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the root cause of the inconsistent timezone display issues — helpers.ts had severe merge conflict leftovers. The file had 4 duplicate definitions of formatDate, 4 of formatTime, and 2 of timeAgo, plus the explorerUrl function had timeAgo logic mixed into it.
This cleans it up: +34 / -216 lines, one correct version of each function, all using Intl.DateTimeFormat with the viewers locale and timezone. Also fixed the markets page which had 5 duplicate import lines from the same merge conflicts.
Closes #70 & #73 — they are the same underlying bug.