-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve media artwork display in MediaRouteControllerDialog
#66
base: RouteInfo_screenshots
Are you sure you want to change the base?
Improve media artwork display in MediaRouteControllerDialog
#66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (3)
- mediarouter-compose/build.gradle.kts: Language not supported
- mediarouter-compose/src/main/java/ch/srgssr/androidx/mediarouter/compose/MediaRouteControllerDialog.kt: Language not supported
- mediarouter-compose/src/screenshotTest/java/ch/srgssr/androidx/mediarouter/compose/MediaRouteControllerDialogScreenshot.kt: Language not supported
Comments suppressed due to low confidence (1)
gradle/libs.versions.toml:67
- [nitpick] The dependency name 'coil-compose-core' is very similar to the existing 'coil-compose' dependency; consider adding a comment or documentation to clarify the distinct purpose of each dependency to avoid confusion.
coil-compose-core = { group = "io.coil-kt.coil3", name = "coil-compose-core", version.ref = "coil" }
Code Coverage
|
62c501f
to
254d855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9d7d318
to
4249c1b
Compare
I've updated the PR so the artwork is displayed now. I've pushed a few commits for specific small changes, the main one being 9d7d318, where I introduce a |
043be6c
to
a10ab27
Compare
4249c1b
to
aafe8ee
Compare
Description
This PR improves the display of the media artwork so it no longer stretches in the
MediaRouteControllerDialog
.Note
It's not possible to use network images in Compose Preview. I also didn't manage to use local images (unless the are in
src/main
, which is not what we want). So for now I'm drawing a simple image.Changes made