Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in labeled content view instead of horizontal stacks where appropriate #1169

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

defagos
Copy link
Member

@defagos defagos commented Mar 18, 2025

Description

This PR replaces manual label layout using HStack, two labels and a spacer, with the native LabeledContent view. This not only ensures correct appearance on all devices but also makes the view itself correctly accessible via VoiceOver for free.

Changes made

Self-explanatory. Note that the line limit of 1 has been removed in the metrics view (URLs now appear in full).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this Mar 18, 2025
@defagos defagos added the enhancement New feature or request label Mar 18, 2025
@defagos defagos enabled auto-merge March 18, 2025 21:21
@defagos defagos added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 0a6c3ed Mar 19, 2025
7 checks passed
@defagos defagos deleted the labeled-content branch March 19, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants