Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message view appearance #1173

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Improve message view appearance #1173

merged 4 commits into from
Mar 21, 2025

Conversation

defagos
Copy link
Member

@defagos defagos commented Mar 21, 2025

Description

This PR enhances our custom message view appearance to more closely match ContentUnavailableView, which is available on iOS / tvOS 17 and above only.

Changes made

  • Update message view appearance.
  • Add message-only support.
  • Display message when there are no items in a playlist.
  • Remove a superfluous frame added to the playlist demo toolbar.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos added the enhancement New feature or request label Mar 21, 2025
@waliid waliid added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit 7b41671 Mar 21, 2025
7 checks passed
@waliid waliid deleted the message-view-redesign branch March 21, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defagos @waliid