PLAYRTS-5578 - iOS 18 Update

[mutaben]

Description

1. A crash was occurring when building against the iOS 18 SDK. On regular horizontal size class, the UITabBar adopts now a new design paradigm. An internal change caused the UITabBar to not live in the same view hierarchy anymore. This caused a crash within the AutoLayout engine because the two views we were trying to constrain together didn't have a common ancestor.
2. The new UITabBar design paradigm caused issues with the Mini Player and the GoogleCast button positions on regular horizontal size class.

This PR solves both issues.

Changes Made

Both issues were fixed by:

• Aligning the Mini Player to the safe area on regular horizontal size class, since the UITabBar is not there anymore anyway. On compact size class, we have to rely on computing the UITabBar's height in order to achieve the same result as the current version.
• The GoogleCast button was misplaced on regular horizontal size class as well, since the new floating UITabBar moves the safe area. It's now fixed manually, which isn't ideal so I'm open to better ways to do it.

Checklist

• I have followed the project's style guidelines.
• I have performed a self-review of my own changes.
• I have made corresponding changes to the documentation.
• My changes do not generate new warnings.
• I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
• I have reviewed the contribution guidelines.

[defagos]

I tested the result in the simulator on iOS 18 and on an iOS 17 device. Two quick feedbacks without diving too much into the code yet:

• Restoring the small vertical space between the player bar and the bottom bar would be nicer IMHO.
• The TV program header seems broken, on iPad at least. Maybe a simulator thing, this needs to be tested on a device running the latest beta.

[defagos]

A suggestion also: You might want to assign the .search role to the corresponding tab item so that it is displayed in the standard position on the right.

[defagos]

A few additional inputs:

• The settings button is also not visible anymore in the Profile section on iPadOS 18.
• When enabling VoiceOver we were extending the player to fill the whole width. I guess this behavior does not make sense on iPadOS 18 anymore (and probably on earlier iPadOS versions too).
• With the new tab bar appearance some titles are lost (e.g. we don't have the radio channel name anymore). Maybe there is nothing that can be done, though.
• The TV program title starts in a broken state also on device (this is fixed by slightly scrolling vertically). Maybe this is still a beta issue, though.
• The color gradients on topic pages has an incorrect offset after scrolling vertically. The back button also exhibits strange behavior.
• I had to tweak the pre-build phase since it failed to locate the associated SRG User Data script. Maybe I missed something in my setup?
• I experience crashes when toggling favorites. Maybe related to the tweak I made, maybe not?

[pyby]

Should we keep the same previous offset for iPadOS previous 18 and introduce an os version check?
The new condition should be only for iPadOS 18 and more.

UI change: no more top and right "look like" same margin on the GoogleCast floating button above the heart stage card.

[pyby]

Running on iPadOS less than 18.0, the mini player is now not visible, as displayed below the bottom tab bar.

The new condition should be only for iPadOS 18 and more.

[pyby]

Are the two contraints compatible in the same time as they are link both to self.miniPlayerView.bottomAnchor?
Do we expect to set active = NO to one, and active = YES to the other one?

[defagos]

Combining the else with the enclosed if is a bit more readable:

Suggested change

	} else {
	if let presentationController {
	config.presentationContext = .viewController(presentationController)
	}
	}
	else if let presentationController {
	config.presentationContext = .viewController(presentationController)

[defagos]

Suggested change

	if (self.traitCollection.horizontalSizeClass == UIUserInterfaceSizeClassRegular) {
	self.playerBottomToViewConstraint.active = NO;
	self.playerBottomToSafeAreaConstraint.active = YES;
	} else {
	self.playerBottomToViewConstraint.active = YES;
	self.playerBottomToSafeAreaConstraint.active = NO;
	}
	BOOL isRegular = (self.traitCollection.horizontalSizeClass == UIUserInterfaceSizeClassRegular);
	self.playerBottomToViewConstraint.active = ! isRegular;
	self.playerBottomToSafeAreaConstraint.active = isRegular;

[defagos]

A few remarks:

• On iOS 17 there is a small offset between the mini player and the tab bar. This makes the layout more readable.
• Using a block to factor out part of the implementation requires awkward block signatures and dereferencing. It is better factored out as a method IMHO (which, BTW, should probably not be related to pre-iOS 18 behavior, as not all code paths are related to such behavior).

The original code is quite poor. If it can help we can try refactoring things a little bit together.