Skip to content

Commit

Permalink
Fix FPlasticSourceControlProvider::UsesFileRevisions() for UE5.5
Browse files Browse the repository at this point in the history
This API introduced in UE5.1 was broken, preventing the user to use the source control context menu for checkin if returning false
It's finally been fixed by merging our PR in ue5-main for UE5.5

So now we can return IsPartialWorkspace(); so the "context update workspace" allowing to update just a selection of files only applies to partial Gluon workspaces
  • Loading branch information
SRombautsU committed May 28, 2024
1 parent 16b151e commit 5842aa4
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,13 @@ bool FPlasticSourceControlProvider::UsesCheckout() const

bool FPlasticSourceControlProvider::UsesFileRevisions() const
{
// This API introduced in UE5.1 is still broken as of UE5.3
// This API introduced in UE5.1 was broken until they finally merged our PR in UE5.5
// (preventing the user to use the source control context menu for checkin if returning false)
// return IsPartialWorkspace();
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION >= 5
return IsPartialWorkspace();
#else
return true;
#endif
}

bool FPlasticSourceControlProvider::UsesSnapshots() const
Expand Down

0 comments on commit 5842aa4

Please sign in to comment.