Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mobile | Fix issue with k6 not running in Docker #916

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Jun 20, 2024

Closes #915

k6 isn't running from the Docker image as the k6-scripts folder never gets copied and so is never able to execute the script file. This fixes it by copying the k6-scripts folder.

Also fixes the download button not working on the k6 page.

341270002-d45b9f0f-e519-49fc-84ff-90e32602cae3

✅ Figure: k6 now runs successfully

@zacharykeeping zacharykeeping changed the base branch from main to staging June 20, 2024 04:34
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit 4f814a3 into staging Sep 13, 2024
1 check passed
@zacharykeeping zacharykeeping deleted the k6-fix branch September 13, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Docker | k6 scan not working
2 participants