Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Component Redesign | Logo Carousel and Image and Accordian Blocks #3389

Closed
wants to merge 204 commits into from
Closed

💄 Component Redesign | Logo Carousel and Image and Accordian Blocks #3389

wants to merge 204 commits into from

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Dec 10, 2024 •
edited by isaaclombardssw
Loading

isaaclombardssw and others added 30 commits November 20, 2024 17:51
@isaaclombardssw
initial commit to setup shadcn
e355173
@isaaclombardssw
added config for shadcn and components.json
d79a048
@isaaclombardssw
merge with main
f65c8b1
@isaaclombardssw
shadcn import setup and breadcrum template code
0034c89
@isaaclombardssw
breadcrumbs component
4294650
@Calinator444
🎨 moved base case to switch statement
4b79730
@isaaclombardssw
breadcrumb component integrated with Tina
13fd61e
@isaaclombardssw
adding a consulting v2 collection (WIP)
6a8521b
@isaaclombardssw
Merge branch 'main' into image-text-block-component
ee8a452
@Calinator444
🪓 Split consulting page into 2 separate routes
a1a2650
@isaaclombardssw
starting the image text block schema
987017a
@isaaclombardssw
starting to create the blocks page
c0a5f67
@Calinator444
💄 Replaced navbar on consultingv2 page with stylistically consistent …
f5db5dd 
…navbar
@Calinator444
🐛 Fixed Breadcrumbs not rendering on new consulting pages
db97e4d
@Calinator444
🏷️ Added explicit typing for Breadcrumbs component
4e49bb5
@Calinator444
♻️ Added variable for initial breadcrumb value
67e7230
@Calinator444
💄 Fixed layout for v2 consulting page
08e17f8
@Calinator444
💄 Updated breadcrumbs to match figma prototype
d012164
@Calinator444
💄offset text underline for breadcrumbs to match figma prototype
ff4377f
@Calinator444
🎨 Added new background color type for new consulting pages
83d59db
@Calinator444
💄Made breadcrumbs thinner to match figma prototype
3ad8113
@Calinator444
✨ Made breadcrumb default to title of the current page
0d76ed4
@Calinator444
✨ updated consulting schema to automatically fill out first breadcrum…
95bd400 
…b when the user leaves it blank
@Calinator444
🐛 Fixed consulting page not saving when no blocks are provided
d012a4a
@Calinator444
🪵 Removed console logging in consultingv2 return
df42391
@Calinator444
💄 Fixed responsive view for breadcrumbs & configured dark mode settings
324be99
@Calinator444
🦺 Added contextual editing for final breadcrumb
e8c198a
@Calinator444
✨ Added option to configure breadcrumb url segments
359d7e7
@Calinator444
Fixed consulting page layout
ebfe88f
@Calinator444
Updated tina info fields to be consistent
9c156fe
@isaaclombardssw isaaclombardssw changed the title Accordian dupe 💄 Component Redesign | Logo Carousel and Image and Accordian Blocks Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 74
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@isaaclombardssw
Copy link
Member

isaaclombardssw commented Dec 10, 2024 •
edited
Loading

Test with Louis....

  • It isn't clear that the filename is the slug, and cannot have spaces
  • SEO options are not clear (in function or if they even apply to these pages)
  • Order the new components at the top and label them in some way
  • Add to image descriptions a recommended size (4/3)
  • Accordian should have a preview image
  • Remove accordion rich text options..... images, quotes, make headings paragraphs

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 68
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 68
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 60
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 67
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 53
SEO 61

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 71
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3389.azurewebsites.net

@amankumarrr amankumarrr deleted the accordian-dupe branch December 23, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Develop the Accordion Block Component
3 participants
@Calinator444 @isaaclombardssw @babakamyljanovssw