Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App router - Migrated /training/internship-fullstack page #3393

Merged
merged 7 commits into from
Dec 16, 2024
Merged

App router - Migrated /training/internship-fullstack page #3393

merged 7 commits into from
Dec 16, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Dec 11, 2024 •
edited
Loading

image
Figure: Performance test for staging page

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.21% 69/32973
🔴 Branches 6.69% 24/359
🔴 Functions 0.89% 3/338
🔴 Lines 0.21% 69/32973

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from b31579e

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 74
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 70
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

Calinator444
Calinator444 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Calinator444 Calinator444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but fix any linting issues

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 65
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 72
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3393.azurewebsites.net

@babakamyljanovssw babakamyljanovssw merged commit b73e671 into main Dec 16, 2024
11 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 3169-training branch December 16, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinator444 Calinator444 Calinator444 approved these changes

@isaaclombardssw isaaclombardssw Awaiting requested review from isaaclombardssw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ App Router migration - Training
2 participants
@babakamyljanovssw @Calinator444