Bring back Offices and Employment to App Router #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implemented page.tsx for dynamic offices pages * implemented index.tsx for dynamic office pages * implemented office page.tsx * implemented office index.tsx * removed pages router implementation for office * renamed for better readability
* migrated employment page to app routing * cleaned up linting errors
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from e724987 |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3421.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3421.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected routes:
/officesand/employmentFixed ♻️ App Router migration - Offices #3168
The offices and employment pages migration to app router was reverted in one of the PRs, so merging those commits