-
Notifications
You must be signed in to change notification settings - Fork 3
[Refactor][jjaeroong]: 팟 시작 날짜/ 종료 날짜 형식 수정(모집 중/끓인 팟),유저 닉네임 생성 시 씨앗과 함께 응답 및 팟 이름 수정 API 변경 #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…과 함께 응답 및 팟 이름 수정 API 변경 [Refactor][jjaeroong]: 팟 시작 날짜/ 종료 날짜 형식 수정(모집 중/끓인 팟),유저 닉네임 생성 시 씨앗과 함께 응답 및 팟 이름 수정 API 변경
|
Caution Review failedThe pull request is closed. Walkthrough컨버터와 DTO 전반에서 팟 시작/종료일을 문자열 기반으로 처리·포맷하도록 변경하고, 상세 응답은 월 단위 포맷을 적용했습니다. 팟 이름 변경 API는 PotController에서 제거되고 MyPotController로 이동했습니다. 멤버 DTO에서 kakaoId가 제거됐으며, 닉네임 생성·저장 로직에 “ 새싹” 접미사 처리 추가가 반영되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor Client
participant MyPotController
participant PotCommandService
Client->>MyPotController: PATCH /my-pots/{pot_id}/rename (PotNameUpdateRequestDto)
MyPotController->>PotCommandService: updatePotName(pot_id, request)
PotCommandService-->>MyPotController: String (result)
MyPotController-->>Client: ApiResponse<String>
sequenceDiagram
participant Client
participant PotConverter
participant DateFormatter
Client->>PotConverter: PotRequestDto(potStartDate, potEndDate)
PotConverter->>PotConverter: toEntity(String.valueOf(...))
PotConverter-->>Client: Pot entity (dates as String)
Client->>PotConverter: entity -> DTO
PotConverter->>DateFormatter: format()/formatToMonth()
DateFormatter-->>PotConverter: formatted String
PotConverter-->>Client: DTO (formatted dates)
sequenceDiagram
actor User
participant UserCommandService
participant Repository
User->>UserCommandService: createNickname()
UserCommandService->>UserCommandService: generate base + " 새싹"
UserCommandService-->>User: NicknameResponseDto (with " 새싹")
User->>UserCommandService: save profile(nickname with " 새싹")
UserCommandService->>UserCommandService: trimNickname(remove " 새싹")
UserCommandService->>Repository: save(base nickname)
Repository-->>UserCommandService: ok
UserCommandService-->>User: success
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
PR 타입(하나 이상의 PR 타입을 선택해주세요)
반영 브랜치
ex) feat/login -> dev
작업 내용
ex) 로그인 시, 구글 소셜 로그인 기능을 추가했습니다.
테스트 결과
ex) 베이스 브랜치에 포함되기 위한 코드는 모두 정상적으로 동작해야 합니다. 결과물에 대한 스크린샷, GIF, 혹은 라이브
Summary by CodeRabbit