Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote arrays addition #644

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remote arrays addition #644

wants to merge 4 commits into from

Conversation

weilewei
Copy link
Contributor

adding a case of element-wise arrays addition using two localities

@weilewei weilewei added this to the 0.0.1 milestone Oct 29, 2018
auto const& code = phylanx::execution_tree::compile(codestr, snippets, env);
return code.run();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't the above functions be unified into one?


auto et2 = compile(code2, there);
et2(a2, b2);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're interested in the result as a whole (i.e. stacking the results together again).

),
code2
))";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code1 and code2 are identical. Do we need both?

@hkaiser
Copy link
Member

hkaiser commented Nov 3, 2018

@weilewei please have a look here for how your code could be simplified and streamlined: https://github.com/STEllAR-GROUP/phylanx/blob/function_call_attributes/tests/unit/distributed/remote_add.cpp

@weilewei
Copy link
Contributor Author

weilewei commented Nov 5, 2018

@hkaiser looks great to me! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants