M4 AP-5: public-API contract lock + as-built reconciliation (closes Milestone M4) - #12
Merged
Merged
Conversation
…2, trackers, CHANGELOG)
…l, AgentRun, retained harness)
…ex, [Unreleased])
Owner
Author
|
Maintainer review — APPROVED for merge ✅ Reviewed from my side. Clean close-out of Milestone M4.
MERGEABLE / CLEAN. Merging — this closes Milestone M4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final slice of Milestone M4 (BYOM recovery library). Locks the public surface and reconciles the documentation-first record with what actually shipped in AP-1–AP-4. No
src/behavior change — one new test + docs/trackers only.tests/test_public_api_contract.py): pins the exact 20-namecairn.__all__, fails on drift (both missing and extra), asserts every name imports, and guards__version__at 0.x (blocks an accidental/unapproved v1.0 bump).recover()has nogoal(carried in the checkpoint), the Agent outcome isAgentRun(notRunResult),Observation/Model/MockModelaren't top-level exports, andCodeHarness.resume/observe_worldwere not force-migrated ontorecover()(the harness interleaves Task-specific env setup — churning the validated benchmark was rejected). Sections 1–11 preserved verbatim.project/phases/milestone-4-byom-library/README.md): mirrors M1–M3; summarizes the 5 slices, what shipped, deviations, honest scope.## [Unreleased]CHANGELOG entry (no version bump — ships nothing outward).Governance
[Unreleased]; the contract test guards the version at 0.x.src/change at all).Test Plan
EXPECTEDequals livecairn.__all__exactly; catches both added and removed names;__version__==0.2.0.src/cairn/recovery.py(nogoal) andsrc/cairn/agent.py(AgentRun).🤖 Generated with Claude Code