Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidelines #1286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add contribution guidelines #1286

wants to merge 1 commit into from

Conversation

dirkmueller
Copy link
Member

No description provided.

dcermak pushed a commit that referenced this pull request Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286
Changes pushed to branch Tumbleweed-1286 as commit 9cb4f9a36846e288c8d17483cb04ce9d3806a789
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for x86_64: current state: published
Build results:

package name status build log
helm-image ✅ succeeded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for aarch64: current state: published
Build results:

package name status build log
helm-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for x86_64: current state: published
Build results:

package name status build log
helm-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for aarch64: current state: published
Build results:

package name status build log
helm-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1286/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1286/images/opensuse/helm
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

Copy link
Member

@alexandrevicenzi alexandrevicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a branch setting that allows these rules to be specified, including auto-merge.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dirkmueller dirkmueller force-pushed the contribution branch 2 times, most recently from 1e0938a to e17019e Compare June 14, 2024 13:21
dcermak pushed a commit that referenced this pull request Jun 14, 2024
Copy link

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286
Changes pushed to branch Tumbleweed-1286 as commit 4b60c2977e2c3a165b69f4f7ef90191785764a76

dcermak pushed a commit that referenced this pull request Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286
Changes pushed to branch Tumbleweed-1286 as commit e85a1dc96a7d3a02fa2ebcaedb05a900f9c7fb43
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for x86_64: current state: published
Build results:

package name status build log
helm-image ✅ succeeded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for aarch64: current state: published
Build results:

package name status build log
helm-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for x86_64: current state: published
Build results:

package name status build log
helm-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1286 for aarch64: current state: published
Build results:

package name status build log
helm-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1286/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1286/images/opensuse/helm
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@dirkmueller
Copy link
Member Author

There's a branch setting that allows these rules to be specified, including auto-merge.

some of the settings can be configured. but the point here is not to have an implementation (implementation can follow the policy) but a written policy that we can tune the implementation then for, once the alignment is around that.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Comment on lines +39 to +43
* A pull request is considered mergeable if it has no outstanding change
requests, at least one approval by the maintainers and sufficient time has
passed. Sufficient time means at least one business day, could be two or
three in case there are multiple people deciding to send in PRs and Dan has a
busy day.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for calling me out personally, but I don't think that mentioning my name improves this document in any way

Suggested change
* A pull request is considered mergeable if it has no outstanding change
requests, at least one approval by the maintainers and sufficient time has
passed. Sufficient time means at least one business day, could be two or
three in case there are multiple people deciding to send in PRs and Dan has a
busy day.
* A pull request is considered mergeable if it has no outstanding change
requests, at least one approval by the maintainers and sufficient time has
passed. Sufficient time means at least one business day, could be two or
three in case there are multiple people deciding to send in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants