Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCI image added for KEA DHCP #1858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BCI image added for KEA DHCP #1858

wants to merge 1 commit into from

Conversation

rcmadhankumar
Copy link
Contributor

No description provided.

@rcmadhankumar rcmadhankumar force-pushed the kea-dhcp branch 10 times, most recently from 3a7a285 to c1ab59c Compare October 17, 2024 07:13
ApplicationStackContainer(
name="kea",
os_version=os_version,
tag_version=get_pkg_version("keadhcp", os_version),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tag_version=get_pkg_version("keadhcp", os_version),
version=get_pkg_version("keadhcp", os_version),

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run poetry run ruff check --fix to organize the imports

dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1858
Changes pushed to branch 7-1858 as commit fbff32c3cd5f5c6b8852703f40d83f9b9d943a5b

Copy link

github-actions bot commented Oct 17, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858
Changes pushed to branch Tumbleweed-1858 as commit 33b1c0bb1549b7a11793500af43dfb2915bf2ae1
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858 for x86_64: current state: published
Build results:

package name status build log
keadhcp-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858 for aarch64: current state: published
Build results:

package name status build log
keadhcp-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858 for x86_64: current state: published
Build results:

package name status build log
keadhcp-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858 for aarch64: current state: published
Build results:

package name status build log
keadhcp-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1858/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1858/containerfile/opensuse/keadhcp:latest

Copy link

github-actions bot commented Oct 17, 2024

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1858
Changes pushed to branch 6-1858 as commit 34e5c6ebc0421111d590ee74beaf6541898193ac

dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
@@ -0,0 +1,33 @@
# KEA DHCP Container

This is an openSUSE Base Container Image for DHCP server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoding openSUSE Base container image is not a good idea, because it is wrong for SLE. use the description placeholder instead.

@@ -0,0 +1,33 @@
# KEA DHCP Container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

{% include 'badges.j2' %}

```ShellSession
podman container runlabel runcwd_dhcp6 \
{{ image.pretty_reference }}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

{% include 'licensing_and_eula.j2' %}

name="keadhcp",
os_version=os_version,
version=format_version(
kea_ver := get_pkg_version("keadhcp", os_version), ParseVersion.MAJOR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the name of a binary package. keadhcp does not actually exist here.

kea_ver := get_pkg_version("keadhcp", os_version), ParseVersion.MAJOR
),
tag_version=format_version(kea_ver, ParseVersion.MINOR),
is_latest=os_version in CAN_BE_LATEST_OS_VERSION,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the license="MPL-2.0" somewhere here.

dcermak pushed a commit that referenced this pull request Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Created a staging project on OBS for 16.0: home:defolos:BCI:Staging:16.0:16.0-1858
Changes pushed to branch 16.0-1858 as commit f832282aee4ac62a15f539954300d597eb5eaf8c
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:16.0:16.0-1858 for x86_64: current state: published
Build results:

package name status build log
init-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
sle16-kernel-module-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-1858 for aarch64: current state: published
Build results:

package name status build log
init-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
sle16-kernel-module-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-1858 for s390x: current state: published
Build results:

package name status build log
init-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
sle16-kernel-module-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-1858 for ppc64le: current state: published
Build results:

package name status build log
init-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
sle16-kernel-module-devel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-1858 for x86_64: current state: published
Build results:

package name status build log
init-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
sle16-kernel-module-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-1858 for aarch64: current state: published
Build results:

package name status build log
init-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
sle16-kernel-module-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-1858 for s390x: current state: published
Build results:

package name status build log
init-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
sle16-kernel-module-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-1858 for ppc64le: current state: published
Build results:

package name status build log
init-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
sle16-kernel-module-devel-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=16.0 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-1858/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-1858/containerfile/bci/bci-init:16.0
  • registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-1858/containerfile/bci/bci-sle16-kernel-module-devel:16.0
  • registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-1858/containerfile/bci/kiwi:10
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

Copy link

github-actions bot commented Oct 17, 2024

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1858
Changes pushed to branch 5-1858 as commit 97f8421b831f9e301eae2c8dced681cc71d445c8
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 17, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
dcermak pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants