-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCI image added for KEA DHCP #1858
base: main
Are you sure you want to change the base?
Conversation
3a7a285
to
c1ab59c
Compare
src/bci_build/package/keadhcp.py
Outdated
ApplicationStackContainer( | ||
name="kea", | ||
os_version=os_version, | ||
tag_version=get_pkg_version("keadhcp", os_version), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag_version=get_pkg_version("keadhcp", os_version), | |
version=get_pkg_version("keadhcp", os_version), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run poetry run ruff check --fix
to organize the imports
c1ab59c
to
69de0d7
Compare
Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1858 |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1858 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1858/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1858 |
69de0d7
to
016ec71
Compare
@@ -0,0 +1,33 @@ | |||
# KEA DHCP Container | |||
|
|||
This is an openSUSE Base Container Image for DHCP server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoding openSUSE Base container image is not a good idea, because it is wrong for SLE. use the description placeholder instead.
@@ -0,0 +1,33 @@ | |||
# KEA DHCP Container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
{% include 'badges.j2' %}
```ShellSession | ||
podman container runlabel runcwd_dhcp6 \ | ||
{{ image.pretty_reference }} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
{% include 'licensing_and_eula.j2' %}
src/bci_build/package/keadhcp.py
Outdated
name="keadhcp", | ||
os_version=os_version, | ||
version=format_version( | ||
kea_ver := get_pkg_version("keadhcp", os_version), ParseVersion.MAJOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the name of a binary package. keadhcp does not actually exist here.
kea_ver := get_pkg_version("keadhcp", os_version), ParseVersion.MAJOR | ||
), | ||
tag_version=format_version(kea_ver, ParseVersion.MINOR), | ||
is_latest=os_version in CAN_BE_LATEST_OS_VERSION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the license="MPL-2.0"
somewhere here.
016ec71
to
5874a4f
Compare
Created a staging project on OBS for 16.0: home:defolos:BCI:Staging:16.0:16.0-1858 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=16.0 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-1858/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1858 |
5874a4f
to
f6a4cf8
Compare
f6a4cf8
to
ff6946c
Compare
ff6946c
to
fe27680
Compare
No description provided.