Add redis container #1869
Open
Add redis container #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
reviewed
Oct 22, 2024
cwh42
force-pushed
the
add_redis_container
branch
from
857fd40
to
2990a61
Compare
dirkmueller
reviewed
Oct 23, 2024
| @@ -484,3 +485,41 @@ def _get_nginx_kwargs(os_version: OsVersion): | |||
| ) | |||
| for os_version in (OsVersion.TUMBLEWEED,) | |||
| ] | |||
|
|
|||
| REDIS_CONTAINERS = [ | |||
There was a problem hiding this comment.
generally looks good to me. there are a couple of small changes still outstanding:
- please move the REDIS_CONTAINERS definition to a src/bci_build/package/redis.py separate module instead. we're trying to slowly phase out appcontainers.py as a lumping collection of containers and instead have one module per container
- consider creating a README.md.j2 under src/bci_build/package/redis/ with some description and usage instructions (I'm working on something similar for the valkey container, there is an open unfinished PR from me on that
- potentially we have to convert this over to a multistage docker build, but that can be done as a followup, so it is only a NIT for now.
dirkmueller
reviewed
Oct 23, 2024
| exposes_tcp=[6379], | ||
| build_recipe_type=BuildType.KIWI, | ||
| ) | ||
| for os_version in ALL_NONBASE_OS_VERSIONS |
There was a problem hiding this comment.
afaik redis is dropped in SP7 and tumbleweed, so we should specify this only for SP6 for now.
There was a problem hiding this comment.
Ok. Then I am a bit late to the party.
Probably we should move to valkey soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a redis container for our Private registry project.
Might be useful for others, too.
Is this the way to contribute new bci images?
Not so inspired by opensuse-redis-image.kiwi any more