Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the full container version for build_version #1982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use the full container version for build_version #1982

wants to merge 1 commit into from

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Nov 11, 2024

No description provided.

dcermak pushed a commit that referenced this pull request Nov 11, 2024
Test build for #1982
4f3a676
dcermak pushed a commit that referenced this pull request Nov 11, 2024
Test build for #1982
8dae573
dcermak pushed a commit that referenced this pull request Nov 11, 2024
Test build for #1982
42f1acb
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1982
Changes pushed to branch 5-1982 as commit 4f3a6761c9bba3e4da01295b9228a39ae302af1e
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1982
Changes pushed to branch 7-1982 as commit 5b86696b7e0c0a0c3645e9b789bedd454b12cf17
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for x86_64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for aarch64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for s390x: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for ppc64le: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for x86_64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ✅ succeeded live log
aspnet-runtime-8.0 ✅ succeeded live log
dotnet-6.0 ✅ succeeded live log
dotnet-8.0 ✅ succeeded live log
dotnet-runtime-6.0 ✅ succeeded live log
dotnet-runtime-8.0 ✅ succeeded live log
kiwi-image ✅ succeeded live log
spack-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for aarch64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for s390x: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1982 for ppc64le: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/containerfile/bci/dotnet-aspnet:6.0
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/containerfile/bci/dotnet-runtime:6.0
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/containerfile/bci/dotnet-sdk:6.0
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/containerfile/bci/kiwi:9
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1982/containerfile/bci/spack:0.21

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1982
Changes pushed to branch 6-1982 as commit 9a29a34b41fd3bd9b3b2a305a30bfe902671e556
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for x86_64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for aarch64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for s390x: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for ppc64le: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ⛔ excluded live log
spack-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for x86_64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ✅ succeeded live log
aspnet-runtime-8.0 ✅ succeeded live log
dotnet-6.0 ✅ succeeded live log
dotnet-8.0 ✅ succeeded live log
dotnet-runtime-6.0 ✅ succeeded live log
dotnet-runtime-8.0 ✅ succeeded live log
kiwi-image ✅ succeeded live log
spack-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for aarch64: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for s390x: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1982 for ppc64le: current state: published
Build results:

package name status build log
aspnet-runtime-6.0 ⛔ excluded live log
aspnet-runtime-8.0 ⛔ excluded live log
dotnet-6.0 ⛔ excluded live log
dotnet-8.0 ⛔ excluded live log
dotnet-runtime-6.0 ⛔ excluded live log
dotnet-runtime-8.0 ⛔ excluded live log
kiwi-image ✅ succeeded live log
spack-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/containerfile/bci/dotnet-aspnet:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/containerfile/bci/dotnet-runtime:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/containerfile/bci/dotnet-sdk:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/containerfile/bci/kiwi:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1982/containerfile/bci/spack:latest

@dcermak dcermak force-pushed the full-version-for-build-version branch from 4b45ea7 to 6a32e01 Compare November 11, 2024 16:09
dcermak pushed a commit that referenced this pull request Nov 11, 2024
Test build for #1982
9a29a34
dcermak pushed a commit that referenced this pull request Nov 11, 2024
Test build for #1982
5b86696
@dcermak dcermak marked this pull request as ready for review November 12, 2024 14:01
dirkmueller
dirkmueller reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're expecting tag_version to be used in various places, e.g. the openqa scripts. I wonder if it wouldn't be simpler to use forcemultiversion instead and then go with buildrelease?

dirkmueller
dirkmueller reviewed Nov 13, 2024
View reviewed changes
src/bci_build/registry.py
Comment on lines +70 to +72
# first try to use the containers full version, if that fails, pick
# tag_version and if that also fails, fall back to the parent's classes
# version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that means switching from a %%..%%` based version to another version will change the behavior. is that really a good idea? seems very dangerous to me.

I think the current setup of "version" being the %%placeholder and "tag_version" being a placeholder-free "stable" version is good enough and more predictable in behavior. I know we fscked it up for kiwi but that has been fixed and there is now a check that tag_version needs to be set if there is a placeholder in version. we could enforce it even more to have tag_version always set which I think would make the behavior more predicatble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller dirkmueller left review comments

@msmeissn msmeissn Awaiting requested review from msmeissn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcermak @dirkmueller