kubectl container image added #2060
Conversation
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/ tox -- -n autoThe following images can be pulled from the staging project:
|
| for os_version in KUBECTL_SUPPORTED_OS_VERSIONS: | ||
| KUBECTL_CONTAINERS.append( |
There was a problem hiding this comment.
coding style nit: in most other containers we use the list comprehension style, e.g.
KUBECTL_CONTAINERS = [
ApplicationStackContainer(....)
for os_version in (OsVersion.TUMBLEWEED,)
]instead of for/append.
| ApplicationStackContainer( | ||
| name="kubectl", | ||
| os_version=os_version, | ||
| version=get_pkg_version("kubernetes", os_version), |
There was a problem hiding this comment.
please make this a placeholder so that not every version update is triggering a git commit.
| os_version=os_version, | ||
| version=get_pkg_version("kubernetes", os_version), | ||
| license="MPL-2.0", | ||
| is_latest=True, |
There was a problem hiding this comment.
only in "os_version in CAN_BE_LATEST_OS_VERSION"
maybe you could simply copy&paste https://github.com/SUSE/BCI-dockerfile-generator/blob/main/src/bci_build/package/cosign.py and simply search and replace "cosign" with "kubernetes-client" to get started?
| version=get_pkg_version("kubernetes", os_version), | ||
| license="MPL-2.0", | ||
| is_latest=True, | ||
| pretty_name="Kubectl Client", |
There was a problem hiding this comment.
there is a multistage missing, e.g. from_target_image.
There was a problem hiding this comment.
This is not strictly necessary, building on base is fine
rcmadhankumar
force-pushed
the
kubectl-container
branch
from
1ffd2fa
to
ebd2680
Compare
| is_latest=True, | ||
| pretty_name="Kubectl Client", | ||
| package_list=["kubernetes-client"], | ||
| entrypoint=["kubectl"], |
| KUBECTL_SUPPORTED_OS_VERSIONS = [ | ||
| OsVersion.TUMBLEWEED, | ||
| ] |
There was a problem hiding this comment.
We ship kubernetes-client in SLES as well:
| KUBECTL_SUPPORTED_OS_VERSIONS = [ | |
| OsVersion.TUMBLEWEED, | |
| ] | |
| from bci_build.os_version import ALL_NONBASE_OS_VERSIONS | |
| KUBECTL_SUPPORTED_OS_VERSIONS = ALL_NONBASE_OS_VERSIONS |
No description provided.