Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl container image (jsc#PED-11241) #2060

Merged
merged 1 commit into from
Jan 13, 2025
Merged

kubectl container image (jsc#PED-11241) #2060

merged 1 commit into from
Jan 13, 2025

Conversation

rcmadhankumar
Copy link
Contributor

No description provided.

dcermak pushed a commit that referenced this pull request Nov 26, 2024
Test build for #2060
cbfbe10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060
Changes pushed to branch Tumbleweed-2060 as commit 7334b09f26938e4f1fab5c7e1568991dfb44b73d
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-1.29-image ⛔ excluded live log
kubectl-1.30-image ⛔ excluded live log
kubectl-1.31-image ⛔ excluded live log
kubectl-1.32-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-1.29-image ⛔ excluded live log
kubectl-1.30-image ⛔ excluded live log
kubectl-1.31-image ⛔ excluded live log
kubectl-1.32-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-1.29-image ✅ succeeded live log
kubectl-1.30-image ✅ succeeded live log
kubectl-1.31-image ✅ succeeded live log
kubectl-1.32-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-1.29-image ✅ succeeded live log
kubectl-1.30-image ✅ succeeded live log
kubectl-1.31-image ✅ succeeded live log
kubectl-1.32-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/containerfile/opensuse/bci/rust:latest
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/containerfile/opensuse/kubectl:latest

dirkmueller
dirkmueller requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

dcermak pushed a commit that referenced this pull request Nov 26, 2024
Test build for #2060
46b15ab
@rcmadhankumar rcmadhankumar force-pushed the kubectl-container branch 2 times, most recently from 15afdb8 to 5feb2ac Compare December 2, 2024 05:40
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
e6db72d
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
6fcb4e0
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
4380267
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2060
Changes pushed to branch 6-2060 as commit 0a1aa01e7b8266163d44a053709cc4595c0a4939
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-1.28-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-1.28-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-1.28-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-1.28-image ⛔ excluded live log
rust-oldstable-image ⛔ excluded live log
rust-stable-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-1.28-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-1.28-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-1.28-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-1.28-image ✅ succeeded live log
rust-oldstable-image ✅ succeeded live log
rust-stable-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2060/containerfile/bci/rust:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2060/containerfile/suse/kubectl:latest

dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
b02eca5
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-2060
Changes pushed to branch 5-2060 as commit ead113196758e437809ea1837e07cc16308d3621
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2060/containerfile/suse/kubectl:1
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2060
Changes pushed to branch 7-2060 as commit 7f1c9a745c7133c1c30e704cd964adb6e00806b6

dirkmueller
dirkmueller requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments. the wrong package name is blocking

dcermak pushed a commit that referenced this pull request Dec 6, 2024
Test build for #2060
4028c1a
dcermak pushed a commit that referenced this pull request Dec 11, 2024
Test build for #2060
5fc6154
dcermak pushed a commit that referenced this pull request Dec 11, 2024
Test build for #2060
267297e
@dirkmueller dirkmueller requested a review from dcermak December 17, 2024 08:37
dcermak
dcermak requested changes Dec 17, 2024
View reviewed changes
@rcmadhankumar rcmadhankumar force-pushed the kubectl-container branch 2 times, most recently from fe34631 to d1c970f Compare January 8, 2025 07:02
dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
257b807
dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
94df9d9
dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
4a28a7f
dcermak
dcermak requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're still only generating one package per SP (see inline comments why)

dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
ad72bf4
dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
de9381d
dcermak pushed a commit that referenced this pull request Jan 8, 2025
Test build for #2060
97b6bef
dcermak
dcermak reviewed Jan 8, 2025
View reviewed changes
src/bci_build/package/kubectl.py Outdated
logo_url="https://raw.githubusercontent.com/kubernetes/kubernetes/master/logo/logo.png",
)
for ver, os_version in (
("1.28", OsVersion.TUMBLEWEED),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.28 doesn't exist on TW. I'd also suggest to mimic the version from TW the same way as we have it for Rust & Go (via a list or a tuple)

Suggested change
("1.28", OsVersion.TUMBLEWEED),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed a model similar to postgres as I found it to be appropriate for this.

for ver, os_version in (
        [
            (kubectl_version, OsVersion.TUMBLEWEED)
            for kubectl_version in ("1.29", "1.30", "1.31", "1.32")
        ]
        + [("1.28", OsVersion.SP6)]
        + [(kubectl_version, OsVersion.SP7) for kubectl_version in ("1.28", "1.30")]
    )

dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
29dd779
dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
e285e68
dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
8ab0fee
dcermak
dcermak reviewed Jan 9, 2025
View reviewed changes
src/bci_build/package/kubectl.py Outdated
Comment on lines 53 to 56
for kubectl_version in ("1.29", "1.30", "1.31", "1.32")
]
+ [("1.28", OsVersion.SP6)]
+ [(kubectl_version, OsVersion.SP7) for kubectl_version in ("1.28", "1.30")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the version tuple into a global variable, then you can leverage it in _is_latest_kubectl

dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
7334b09
dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
0a1aa01
dcermak pushed a commit that referenced this pull request Jan 9, 2025
Test build for #2060
c530987
dcermak pushed a commit that referenced this pull request Jan 13, 2025
Test build for #2060
7f1c9a7
@dirkmueller dirkmueller merged commit aa8a72e into main Jan 13, 2025
7 of 8 checks passed
@dirkmueller dirkmueller deleted the kubectl-container branch January 13, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller dirkmueller approved these changes

@alexandrevicenzi alexandrevicenzi alexandrevicenzi approved these changes

@dcermak dcermak dcermak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcmadhankumar @msmeissn @dirkmueller @alexandrevicenzi @dcermak