replace BASALT mentions by SLCC #949
Conversation
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-TuwWm |
|
You'll also have to adjust all the files in .github/workflows 🙈 |
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-GcZTK |
Priyankasaggu11929
force-pushed
the
replace-basalt-to-slci
branch
from
6debc51
to
98f191c
Compare
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-wASnA |
|
Thanks Dan. 😄 Created an empty SLCI branch, and updated the gh workflows. One of the CI job is failing due to missing "SLCI" obs sub-project |
|
Yes, the issue is that devel:BCI:SLCI does not exist on OBS (yet). But I'd wait with creating it, as we do not have the final name for SLCI (yet…) |
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-dYNMv |
Priyankasaggu11929
force-pushed
the
replace-basalt-to-slci
branch
from
30a03a6
to
e0e758f
Compare
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-nuuRs Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
The name is not fixed yet. The purpose of this PR is mostly to find out what breaks and what needs adjustment. |
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-wnMwD Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-blKBz Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-aJwex Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
dcermak
force-pushed
the
replace-basalt-to-slci
branch
from
5e157c2
to
dd3e9e7
Compare
|
Created a staging project on OBS for SLCC-paid: home:defolos:BCI:Staging:SLCC:paid:SLCC-paid-949 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build failed ❌ To run BCI-tests against this PR, use the following command: OS_VERSION=slcc-paid TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/slcc/paid/slcc-paid-949/ tox -- -n autoThe following images can be pulled from the staging project:
|
|
Created a staging project on OBS for SLCC-free: home:defolos:BCI:Staging:SLCC:free:SLCC-free-949 |
|
Created a staging project on OBS for SLCC-paid: home:defolos:BCI:Staging:SLCC:paid:SLCC-paid-949 |
dcermak
force-pushed
the
replace-basalt-to-slci
branch
from
9a7e7c8
to
960d501
Compare
src/bci_build/package/slcc_base.py
Outdated
| @@ -54,7 +60,7 @@ | |||
| rpm -e compat-usrmerge-tools | |||
|
|
|||
| # FIXME: stop hardcoding the url, use some external mechanism once available | |||
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-basalt | |||
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-slci | |||
|
can you please split this into chunks? this is not easily reviewable as a couple of completely unrelated things are lumped together. all the refactorings could be separate and go in already.. |
dcermak
force-pushed
the
replace-basalt-to-slci
branch
from
960d501
to
59e8930
Compare
| @@ -135,7 +136,7 @@ def _envsubst_pkg_name(os_version: OsVersion) -> str: | |||
| CMD /usr/lib/dirsrv/dscontainer -H | |||
| """, | |||
| ) | |||
| for os_version in ALL_NONBASE_OS_VERSIONS | |||
| for os_version in ALL_BASE_OS_VERSIONS | |||
There was a problem hiding this comment.
this seems wrong for appcontainers
src/bci_build/package/__init__.py
Outdated
|
|
||
| for name in [self.name] + self.additional_names: | ||
| tags += [ | ||
| f"{self._registry_prefix}/bci-{name}:%OS_VERSION_ID_SP%", | ||
| f"{self._registry_prefix}/bci-{name}:{self.version_label}", | ||
| f"{self._registry_prefix}/{prefix}{name}:%OS_VERSION_ID_SP%", |
There was a problem hiding this comment.
why are we removing the bci- prefix from the container names here?
| @@ -19,6 +19,8 @@ jobs: | |||
| - 6 | |||
| - 5 | |||
| - Tumbleweed | |||
| - SLCC-free | |||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class TripleZeroPackageGroups: |
There was a problem hiding this comment.
can we split all those TripleZero packages groups commits to the bot into a separate PR? it's messy enough as is to review this and it seems entirely orthogonal to SLCC enablement.
|
|
||
| USERS_FOR_STAGING = ["avicenzi", "dancermak"] | ||
|
|
||
| META_TEMPLATE = jinja2.Template("""<project name="{{ project_name }}"> |
There was a problem hiding this comment.
same project_setup could be an entirely separate PR
- adjust build tags & labels - move distribution_base_name into OsVersion class
…patching devel:BCI
dcermak
force-pushed
the
replace-basalt-to-slci
branch
from
59e8930
to
f3279ee
Compare
copy of #948