Enable SP7 testing #582
Open
Enable SP7 testing #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcermak rebase? we need to get this in soonish when 15.7 development starts (I'd be fine with testing all of base/minimal for now, similar to how 16.0 is enabled) |
dcermak
force-pushed
the
sp7
branch
3 times, most recently
from
8d43acb
to
ed82c7c
Compare
the xfail will ensure that we get failures once the repo becomes available
| @@ -376,6 +376,13 @@ def test_no_orphaned_packages(container_per_test: ContainerData) -> None: | |||
| @pytest.mark.parametrize( | |||
| "container", CONTAINERS_WITH_ZYPPER_AS_ROOT, indirect=True | |||
| ) | |||
| @pytest.mark.xfail( | |||
There was a problem hiding this comment.
This seems to break tests on 15.4.
There was a problem hiding this comment.
yeah, because they're run on a non-suse host so the container-suseconnect integration is not working. rather than adding a quirk in the tests for this, maybe we should simply not define a repo like in the 16.0 case?
dirkmueller
reviewed
Oct 18, 2024
| @@ -167,6 +165,14 @@ jobs: | |||
| os_version: "16.0" | |||
| - toxenv: kernel_module | |||
| os_version: "16.0" | |||
| - toxenv: all | |||
| os_version: "15.7" | |||
There was a problem hiding this comment.
although don't have a strong opinion, I think sorting these before the "16.0" section would be slightly more logical.
dirkmueller
reviewed
Oct 18, 2024
| @@ -519,7 +519,7 @@ def create_BCI( | |||
| ) | |||
| PYTHON311_CONTAINER = create_BCI( | |||
| build_tag="bci/python:3.11", | |||
| available_versions=_DEFAULT_NONBASE_OS_VERSIONS, | |||
| available_versions=["15.6", "tumbleweed"], | |||
There was a problem hiding this comment.
python 311 is still available with SP7, why this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not work properly before we have the SLE 15 SP7 BCI repo
This fixes #545